Introduce blocking circuit create & prove #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔄 Pull Request
📝 Description
For some use cases, an async circuit create or prove method doesn't fit within a user's codebase. Here, we introduce simple blocking analogues of
circuit_createandcircuit_proveas convenience methods. They spawn a runtime so its not a perfect fit for all applications but it balances to the tradeoff of adding a convenience method without a bunch of complexity. GEFN.🔗 Related Tickets & Documents
📋 Type of PR (check all applicable)
💭 Developer Notes
Important note: during testing of this PR, I uncovered some issues with docs testing and suppressed them. That would be any of the
ignoreadditions. Created an issue to come back to when we are at the stage of publishing docs.🧪 Testing Instructions
Integration tests include both new blocking methods and pass.
✅ Testing Status