dbus module refactor + Volume implementation
#42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Created a new module to store functions that register the MPRIS interfaces - Removed a few unwraps - Fixed a few clippy lints
- Check if the D-Bus connection has been succesfully created before launching the thread. This way we can handle the error before anything occurs. - Check if the thread isn't running or has panicked at every method call of `MediaControls`.
|
I'll do some extra checks tomorrow and finally merge and release this. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was probably better to split these changes into different PRs but well, here we are.
This PR includes:
dbusmodule:MediaControls.dbusandzbusmodules. Fixes Linux: Volume control #36This release should not break previous usages of MediaControls with the
dbusbackend. The plan is to merge this PR and release 0.7.0, so the apps can implement the volume controls without waiting for the major refactor which is coming.After this PR, I'm planning to migrate to zbus completely, since the library we use for
dbuscan be a bit annoying to work with at times because of the usage of the underlying C library, which has various side effects, e.g. places weird constraints on lifetimes, has a black-box errordbus::Errorwhich is just a string, has non-static interface generation. This are most probably the hard limitations of the library being a C wrapper.