dbus
module refactor + Volume implementation
#42
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was probably better to split these changes into different PRs but well, here we are.
This PR includes:
dbus
module:MediaControls
.dbus
andzbus
modules. Fixes Linux: Volume control #36This release should not break previous usages of MediaControls with the
dbus
backend. The plan is to merge this PR and release 0.7.0, so the apps can implement the volume controls without waiting for the major refactor which is coming.After this PR, I'm planning to migrate to zbus completely, since the library we use for
dbus
can be a bit annoying to work with at times because of the usage of the underlying C library, which has various side effects, e.g. places weird constraints on lifetimes, has a black-box errordbus::Error
which is just a string, has non-static interface generation. This are most probably the hard limitations of the library being a C wrapper.