Fix LenientRuntimeEnumExtender finalizing fields

Fixes #571
Sinytra · Dec 3, 2023 · 05ef067 · 05ef067
1 parent ca2e4ed
commit 05ef067
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/gradle.properties b/gradle.properties
@@ -4,7 +4,7 @@ org.gradle.jvmargs=-Xmx3G
 org.gradle.daemon=true
 
 # Versions
-versionConnector=1.0.0-beta.28
+versionConnector=1.0.0-beta.29
 versionAdapter=1.8.16-1.20.1-20231120.221506
 versionAdapterDefinition=1.8.21
 

diff --git a/src/main/java/dev/su5ed/sinytra/connector/service/LenientRuntimeEnumExtender.java b/src/main/java/dev/su5ed/sinytra/connector/service/LenientRuntimeEnumExtender.java
@@ -22,9 +22,12 @@ public int processClassWithFlags(Phase phase, ClassNode classNode, Type classTyp
             FieldNode node = values.get(0);
             if ((node.access & Opcodes.ACC_FINAL) == 0) {
                 // It is likely a mixin already made the field mutable
-                // Make it final before it is processed and de-finalized again by super
+                // Make it final before it is processed
                 node.access |= Opcodes.ACC_FINAL;
-                return super.processClassWithFlags(phase, classNode, classType, reason);
+                int result = super.processClassWithFlags(phase, classNode, classType, reason);
+                // Return to original state
+                node.access &= ~Opcodes.ACC_FINAL;
+                return result;
             }
         }
         // Let super deal with this