Provided default baseDir option in grunt task #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@simonrobb I was just checking to see if you had a CLA on file and couldn't find one. Do you have either a CLA with the Dojo Foundation or the jQuery Foundation? If so, could you let me know the details and if not, could you take a moment and file one? |
|
@kitsonk no, I didn't. Just completed one - try searching for my name (Simon Robb). If nothing comes up I'll send you my email address. |
dylans
suggested changes
Jan 12, 2017
There was a problem hiding this comment.
Looks like we just need to rebase and retest this, and then I'll finally land this. Sorry this took so long @simonrobb !
|
Pushing out to 2.2.0 as there are still changes to review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.