-
Notifications
You must be signed in to change notification settings - Fork 7
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixed issue rendering nested empty placeholders (#6)
Currently, empty Placeholders are not rendering the same HTML that JSS does. This PR updates the SDK's TagHelper to generate HTML that matches the same output from JSS. ## Description / Motivation When a Placeholder is rendered without any components loaded inside of it, it needs to be wrapped in a div to be correctly rendered in Pages and Experience Editor. The div being created by for this SDK is `<div className=\"sc-empty-placeholder\"></div>` ## Testing - [x] The Unit & Intergration tests are passing. - [x] I have added the necesary tests to cover my changes. ## Terms - [x] I agree to follow this project's [Code of Conduct](CODE_OF_CONDUCT.md). --------- Co-authored-by: Ivan Lieckens <[email protected]>
- Loading branch information
1 parent
b6387b9
commit 4967f4b
Showing
2 changed files
with
68 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters