Add GetRawValue() to return raw JSON in JsonSerializedField. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sc-ivanlieckens
requested changes
Aug 16, 2024
src/Sitecore.AspNetCore.SDK.LayoutService.Client/Serialization/Fields/JsonSerializedField.cs
Outdated
Show resolved
Hide resolved
jbreuer
changed the title
jbreuer
changed the title
sc-ivanlieckens
previously approved these changes
Aug 22, 2024
|
@jbreuer I was a bit too quick in accepting, still missing a Unit Test to cover this :) |
The unit test has been added. |
sc-ivanlieckens
approved these changes
Aug 28, 2024
|
@jbreuer I believe CodeQL on your fork is disabled causing it not to run for this PR and it's blocking merging. Could you have a look? |
I've enabled CodeQL on my fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces an
GetRawValue()method in theJsonSerializedFieldclass to directly return the raw JSON string. This enhancement provides a more straightforward and efficient way to access the underlying JSON without the need for additional deserialization.Motivation
The primary motivation for this change is to simplify the process of working with JSON data, particularly in scenarios where the JSON is deserialized, modified, and then re-serialized. In my case, I needed to deserialize JSON into a
SitecoreLayoutResponseContentobject, apply modifications, and then serialize it back to JSON. Previously, this required a customJsonConverterthat accessed the_jsonfield via reflection. With this improvement, such workarounds are no longer necessary, making the code cleaner and more maintainable.