Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Engine Node from SUGCON package.json files #409

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

robearlam
Copy link
Member

Vercel have removed support for Node12, which has broken our builds. A better solution is to remove the engine definition from our package.json, allowing the engine to be defined within the Vercel dashboard itself. This PR makes that change.

Closes #408

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the Contributing guide.
  • My code/comments/docs fully adhere to the Code of Conduct.
  • My change is a code change.
  • My change is a documentation change and there are NO other updates required.

@robearlam robearlam added bug Something isn't working SUGCON Sites labels Mar 14, 2024
@robearlam robearlam self-assigned this Mar 14, 2024
@robearlam robearlam marked this pull request as ready for review March 14, 2024 23:48
Copy link
Contributor

@thomas-desmond thomas-desmond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@robearlam robearlam merged commit cb84c0f into main Mar 15, 2024
15 checks passed
@robearlam robearlam deleted the 408-node-engine-version-bug branch March 15, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working SUGCON Sites
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vercel builds are failing due to incorrect node engine version
2 participants