Rebranding applying new styles #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
November 5, 2024 12:22
mrtamasvarga
requested review from
robearlam,
lovesitecore and
sc-ivanlieckens
sc-ivanlieckens
approved these changes
Nov 12, 2024
| <div class="container"> | ||
| <div class="row inner "> |
There was a problem hiding this comment.
Indentation is off?
| @@ -60,6 +62,8 @@ | |||
| </ul> | |||
| </nav> | |||
| </div> | |||
| </div> | |||
| <h5 class="card-title">@Model.Name</h5> | ||
| </a> | ||
| <p class="card-text"><i class="fa fa-globe" aria-hidden="true"></i> @Model.Country</p> | ||
|
|
There was a problem hiding this comment.
Lingering whitespace?
| @@ -5,6 +5,8 @@ | |||
| { | |||
| <section class="mvp-fp-profile bg-white"> | |||
| <div class="container"> | |||
| <div class="row inner "> | |||
| <div class="feature-panel-text with-background no-number"> | ||
| <h2 asp-for="@Model.Fields!.ItemTitle"></h2> | ||
| <div class="feature-panel-card"> | ||
| <div class="feature-panel-text no-number "> |
There was a problem hiding this comment.
double space and trailing space in class? Does this do anything specific? I noticed this a few times
| <p asp-for="@Model.Fields!.ItemText"></p> | ||
|
|
||
| <a asp-for="@Model.Fields!.ItemLink" data-module="cta-button" data-goals="" class="link-arrow" aria-label="Learn more"> | ||
| @Model.Fields?.ItemLink?.Value.Text | ||
| <img alt="Learn more" src="images/icon-arrow.png"> | ||
| </a> | ||
| </div> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
How Has This Been Tested?
Types of changes
Checklist: