Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix local container setup #494

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Fix local container setup #494

merged 2 commits into from
Nov 25, 2024

Conversation

sc-ivanlieckens
Copy link
Collaborator

Description / Motivation

Fixes being able to use local containers

EdgeContextId mode doesn't work with local containers making one unable to access changed layout and content

How Has This Been Tested?

Manual Testing

Local Machine Docker Setup

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the Contributing guide.
  • My code/comments/docs fully adhere to the Code of Conduct.
  • My change is a code change.
  • My change is a documentation change and there are NO other updates required.

@sc-ivanlieckens sc-ivanlieckens added bug Something isn't working MVP Site labels Nov 25, 2024
@robearlam robearlam merged commit b22c6bd into main Nov 25, 2024
3 checks passed
@robearlam robearlam deleted the fix/local-containers branch November 25, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robearlam robearlam robearlam approved these changes

Assignees
No one assigned
Labels
bug Something isn't working MVP Site
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sc-ivanlieckens @robearlam @IvanLieckens