Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vanishing Fields Fix + Character Limits on TextAreas + Sentiment #497

Merged
merged 3 commits into from
Nov 29, 2024

Conversation

sc-ivanlieckens
Copy link
Collaborator

@sc-ivanlieckens sc-ivanlieckens commented Nov 28, 2024

Description / Motivation

  1. Textareas in MVP Application form now have a 2000 char limit enforced and visualized
  2. Sentiment is now visible on score cards
  3. Fixed a bug that would remove Objecties, Eligibility and Mentor data
  1. CF Firewall blocks large submissions in a single field, this attempts to prevent CF Firewall issues
  2. New reviews have a "sentiment" which needed to be visualized for the scoring
  3. Fixing the PATCH operation not to ignore "null" values in Fixed patch application Mvp.Selections.Api#67 exposed the form abusing this to do a quick status change

How Has This Been Tested?

Manual Testing

Local Docker Setup (including API and DB)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the Contributing guide.
  • My code/comments/docs fully adhere to the Code of Conduct.
  • My change is a code change.
  • My change is a documentation change and there are NO other updates required.

@sc-ivanlieckens sc-ivanlieckens added bug Something isn't working enhancement New feature or request MVP Site labels Nov 28, 2024
@sc-ivanlieckens sc-ivanlieckens changed the title Character Limits on TextAreas + Sentiment Vanishing Fields Fix + Character Limits on TextAreas + Sentiment Nov 29, 2024
@mrtamasvarga mrtamasvarga self-requested a review November 29, 2024 08:36
@sc-ivanlieckens sc-ivanlieckens merged commit 755bdea into main Nov 29, 2024
3 checks passed
@sc-ivanlieckens sc-ivanlieckens deleted the feat/char-limits branch November 29, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request MVP Site
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants