[XM Cloud][Angular] Navigation component link forces full page reload #1958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
art-alexeyenko
approved these changes
Oct 24, 2024
art-alexeyenko
requested changes
Oct 24, 2024
|
@art-alexeyenko Good catch! I forgot to update other components. Additionally, I updated Title, Image components and used "scGenericLink" since the link can be both relative and absolute |
art-alexeyenko
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
In order to perform the client side routing without the full page refresh we need to use "scRouterLink" in Navigation component instead of regular "scLink"
Testing Details
Types of changes