Skip to content

Commit

Permalink
Removed SCSS Skatepark Assets, fixed issue with local Bootstrap refer…
Browse files Browse the repository at this point in the history
…ence (#6)

This PR removes the SCSS assets used to build the SkatePark and also
fixes a bug from switching to a local instance of the Bootstrap assets.

The compiled CSS is kept and renamed from `main.css` to `skatepark.css`.
This should make it obvious it developers starting a new project that
can be removed.
  • Loading branch information
robearlam authored Sep 1, 2024
1 parent 5582ff5 commit 55775cf
Show file tree
Hide file tree
Showing 109 changed files with 2 additions and 7,095 deletions.
3 changes: 0 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,6 @@ This Github repository is a template that can be used to create your own reposit
29. Click on the Pages icon
30. You will be taken to your Pages instance, which is now connected to the head application running on your local devleoper machine. You can now add and remove components from the page and see the changes reflected in real-time. Please note the known issues stated above to see which components are not yet supported.

## Building SASS Stylesheet
The included SASS stylesheets are built using the `Web Compiler` extension for Visual Studio. This decision was taken to remove the need for a Node dependency being required to build the stylesheets. The `Web Compiler` extension will automatically compile the SASS files into CSS when the solution is built. If you do not have the `Web Compiler` extension installed you can download it from the Visual Studio Marketplace [here](https://marketplace.visualstudio.com).

## Disconnected offline development
It is possible to mock a small subset of the XM Cloud Application elements to enable offline development. This can allow for a disconnected development experience, however it is recommend to work in the default connected mode.

Expand Down
4 changes: 2 additions & 2 deletions headapps/aspnet-core-starter/Views/Shared/_Layout.cshtml
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
<title>@Model.DisplayName</title>
<meta charset="utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no" />
<link rel="stylesheet" href="/styles/bootstrap-5.1.3.min.css" integrity="sha384-1BmE4kWBq78iYhFldvKuhfTAU6auU8tT94WrHftjDbrCEXSU1oBoqyl2QvZ6jIW3" crossorigin="anonymous">
<link rel="stylesheet" href="/styles/main.min.css" />
<link rel="stylesheet" href="/styles/bootstrap-5.1.3.min.css">
<link rel="stylesheet" href="/styles/skatepark.min.css" />
</head>

<body>
Expand Down
12 changes: 0 additions & 12 deletions headapps/aspnet-core-starter/aspnet-core-starter.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,6 @@
<RootNamespace>Sitecore.AspNetCore.Starter</RootNamespace>
</PropertyGroup>

<ItemGroup>
<Content Remove="compilerconfig.json" />
</ItemGroup>

<ItemGroup>
<_ContentIncludedByDefault Remove="compilerconfig.json" />
</ItemGroup>

<ItemGroup>
<Using Include="Sitecore.AspNetCore.SDK.LayoutService.Client.Extensions" />
<Using Include="Sitecore.AspNetCore.SDK.RenderingEngine.Extensions" />
Expand All @@ -28,8 +20,4 @@
<PackageReference Include="Sitecore.AspNetCore.SDK.ExperienceEditor" />
</ItemGroup>

<ItemGroup>
<None Include="compilerconfig.json" />
</ItemGroup>

</Project>
48 changes: 0 additions & 48 deletions headapps/aspnet-core-starter/assets/basic/_component.scss

This file was deleted.

64 changes: 0 additions & 64 deletions headapps/aspnet-core-starter/assets/basic/_container.scss

This file was deleted.

3 changes: 0 additions & 3 deletions headapps/aspnet-core-starter/assets/basic/_fonts.scss

This file was deleted.

31 changes: 0 additions & 31 deletions headapps/aspnet-core-starter/assets/basic/_footer.scss

This file was deleted.

49 changes: 0 additions & 49 deletions headapps/aspnet-core-starter/assets/basic/_header.scss

This file was deleted.

150 changes: 0 additions & 150 deletions headapps/aspnet-core-starter/assets/basic/_navigation.scss

This file was deleted.

Loading

0 comments on commit 55775cf

Please sign in to comment.