Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider making all constructors protected instead of private #1733

Closed
Jym77 opened this issue Dec 12, 2024 · 1 comment
Closed

Consider making all constructors protected instead of private #1733

Jym77 opened this issue Dec 12, 2024 · 1 comment
Labels
Improvement Surface improvement to API, code, QoL, …

Comments

@Jym77
Copy link
Contributor

Jym77 commented Dec 12, 2024

Most of our classes constructors are private. This effectively prevents the classes to be extended as it prevents a call to super.
We should maybe make them protected which would let consumers extends the classes if they want to enrich the data.
@Jym77 Jym77 added the Improvement Surface improvement to API, code, QoL, … label Dec 12, 2024
@Jym77 Jym77 mentioned this issue Dec 18, 2024
Merged
@Jym77 Jym77 moved this from 📮 Backlog to 🧑‍💻 Doing in ⚙️ Alfa Development Dec 18, 2024
@Jym77 Jym77 mentioned this issue Dec 18, 2024
Merged
@Jym77
Copy link
Contributor Author

Jym77 commented Dec 18, 2024

Done.

@Jym77 Jym77 closed this as completed Dec 18, 2024
@github-project-automation github-project-automation bot moved this from 🧑‍💻 Doing to 🏁 Done in ⚙️ Alfa Development Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Improvement Surface improvement to API, code, QoL, …
Projects
⚙️ Alfa Development
Status: 🏁 Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Jym77