Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protected constructors #1735

Merged
merged 5 commits into from
Dec 18, 2024
Merged

Protected constructors #1735

merged 5 commits into from
Dec 18, 2024

Conversation

Jym77
Copy link
Contributor

@Jym77 Jym77 commented Dec 18, 2024

Part of #1733

  • Make constructors that are not part of a Singleton pattern protected instead of private. This let consumers extend the class if they want.
  • Fix a missing singleton pattern.

Copy link

changeset-bot bot commented Dec 18, 2024

🦋 Changeset detected

Latest commit: 21b0c85

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 78 packages
Name Type
@siteimprove/alfa-compatibility Patch
@siteimprove/alfa-css-feature Patch
@siteimprove/alfa-performance Patch
@siteimprove/alfa-trampoline Patch
@siteimprove/alfa-rectangle Patch
@siteimprove/alfa-selective Patch
@siteimprove/alfa-toolchain Patch
@siteimprove/alfa-branched Patch
@siteimprove/alfa-selector Patch
@siteimprove/alfa-sequence Patch
@siteimprove/alfa-cascade Patch
@siteimprove/alfa-emitter Patch
@siteimprove/alfa-network Patch
@siteimprove/alfa-affine Patch
@siteimprove/alfa-device Patch
@siteimprove/alfa-either Patch
@siteimprove/alfa-future Patch
@siteimprove/alfa-option Patch
@siteimprove/alfa-record Patch
@siteimprove/alfa-result Patch
@siteimprove/alfa-cache Patch
@siteimprove/alfa-graph Patch
@siteimprove/alfa-rules Patch
@siteimprove/alfa-slice Patch
@siteimprove/alfa-style Patch
@siteimprove/alfa-table Patch
@siteimprove/alfa-xpath Patch
@siteimprove/alfa-aria Patch
@siteimprove/alfa-http Patch
@siteimprove/alfa-iana Patch
@siteimprove/alfa-lazy Patch
@siteimprove/alfa-list Patch
@siteimprove/alfa-time Patch
@siteimprove/alfa-wcag Patch
@siteimprove/alfa-act Patch
@siteimprove/alfa-css Patch
@siteimprove/alfa-dom Patch
@siteimprove/alfa-fnv Patch
@siteimprove/alfa-map Patch
@siteimprove/alfa-set Patch
@siteimprove/alfa-url Patch
@siteimprove/alfa-web Patch
@siteimprove/alfa-applicative Patch
@siteimprove/alfa-array Patch
@siteimprove/alfa-bits Patch
@siteimprove/alfa-callback Patch
@siteimprove/alfa-clone Patch
@siteimprove/alfa-collection Patch
@siteimprove/alfa-comparable Patch
@siteimprove/alfa-continuation Patch
@siteimprove/alfa-earl Patch
@siteimprove/alfa-encoding Patch
@siteimprove/alfa-equatable Patch
@siteimprove/alfa-flags Patch
@siteimprove/alfa-foldable Patch
@siteimprove/alfa-functor Patch
@siteimprove/alfa-generator Patch
@siteimprove/alfa-hash Patch
@siteimprove/alfa-iterable Patch
@siteimprove/alfa-json-ld Patch
@siteimprove/alfa-json Patch
@siteimprove/alfa-mapper Patch
@siteimprove/alfa-math Patch
@siteimprove/alfa-monad Patch
@siteimprove/alfa-parser Patch
@siteimprove/alfa-predicate Patch
@siteimprove/alfa-promise Patch
@siteimprove/alfa-reducer Patch
@siteimprove/alfa-refinement Patch
@siteimprove/alfa-sarif Patch
@siteimprove/alfa-string Patch
@siteimprove/alfa-test-deprecated Patch
@siteimprove/alfa-test Patch
@siteimprove/alfa-thenable Patch
@siteimprove/alfa-thunk Patch
@siteimprove/alfa-tree Patch
@siteimprove/alfa-trilean Patch
@siteimprove/alfa-tuple Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Jym77 Jym77 self-assigned this Dec 18, 2024
@Jym77 Jym77 added the patch Backwards-compatible change that doesn't touch public API label Dec 18, 2024
@Jym77
Copy link
Contributor Author

Jym77 commented Dec 18, 2024

!pr extract

@Jym77 Jym77 marked this pull request as ready for review December 18, 2024 14:50
@Jym77 Jym77 requested a review from a team as a code owner December 18, 2024 14:50
@Jym77 Jym77 added this pull request to the merge queue Dec 18, 2024
Merged via the queue into main with commit 4fc908d Dec 18, 2024
4 checks passed
@Jym77 Jym77 deleted the protected-constructors branch December 18, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Backwards-compatible change that doesn't touch public API
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants