Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compute accessible name correctly from the content #1200

Merged
merged 6 commits into from
Jul 28, 2022
Merged

Compute accessible name correctly from the content #1200

merged 6 commits into from
Jul 28, 2022

Conversation

zsofitoth
Copy link

Resolves #1054

@zsofitoth zsofitoth marked this pull request as ready for review July 22, 2022 11:06
@zsofitoth zsofitoth requested review from a team and Jym77 July 22, 2022 11:06
@zsofitoth zsofitoth marked this pull request as draft July 22, 2022 11:58
@zsofitoth
Copy link
Author

Converting back to draft, seems like the name testable statements caught some things

@Jym77
Copy link
Contributor

Jym77 commented Jul 22, 2022

Converting back to draft, seems like the name testable statements caught some things

Yes, this should precisely fix one of the test exceptions 😀 (with ref to the same issue).
Should be just deleting the corresponding bit of the switch + re-generating the test file 🤞

@zsofitoth zsofitoth marked this pull request as ready for review July 22, 2022 13:21
@zsofitoth zsofitoth self-assigned this Jul 25, 2022
@zsofitoth zsofitoth added the patch Backwards-compatible change that doesn't touch public API label Jul 26, 2022
@zsofitoth zsofitoth enabled auto-merge (squash) July 27, 2022 09:49
@zsofitoth zsofitoth merged commit 93a77ed into main Jul 28, 2022
@zsofitoth zsofitoth deleted the zto/compute-accessible-name-from-content-correctly branch July 28, 2022 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jym77 Jym77 Jym77 approved these changes

Assignees

@zsofitoth zsofitoth

Labels
patch Backwards-compatible change that doesn't touch public API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Accessible name from content is not computed correctly in case of display: block descendants
2 participants
@zsofitoth @Jym77