Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SIA-R16, SIA-R19: Make open combobox require aria-controls #1381

Merged
merged 10 commits into from
Mar 22, 2023
Merged

SIA-R16, SIA-R19: Make open combobox require aria-controls #1381

merged 10 commits into from
Mar 22, 2023

Conversation

Jym77
Copy link
Contributor

@Jym77 Jym77 commented Mar 21, 2023

Resolves #1379

@Jym77 Jym77 self-assigned this Mar 21, 2023
@Jym77 Jym77 added the minor Backwards-compatible change that touches public API label Mar 21, 2023
@Jym77 Jym77 marked this pull request as ready for review March 21, 2023 11:56
@Jym77 Jym77 requested review from a team and rcj-siteimprove March 21, 2023 11:56
rcj-siteimprove
rcj-siteimprove approved these changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@rcj-siteimprove rcj-siteimprove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🙂

@Jym77 Jym77 added this pull request to the merge queue Mar 22, 2023
@Jym77 Jym77 merged commit 9149d6a into main Mar 22, 2023
@Jym77 Jym77 deleted the open-combobox-require-aria-controls branch March 22, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcj-siteimprove rcj-siteimprove rcj-siteimprove approved these changes

Assignees

@Jym77 Jym77

Labels
minor Backwards-compatible change that touches public API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SIA-R16/SIA-R19: aria-controls on combobox with aria-expanded="true" should be considered as required
2 participants
@Jym77 @rcj-siteimprove