Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use buttonface for UA <button> background color #1472

Merged
merged 2 commits into from
Sep 26, 2023
Merged

Use buttonface for UA <button> background color #1472

merged 2 commits into from
Sep 26, 2023

Conversation

Jym77
Copy link
Contributor

@Jym77 Jym77 commented Sep 21, 2023

Previously, it defaulted to the initial transparent color, which could cause unintended behaviours when computing color contrast since unstyled <button> were essentially see-through 🙈

@Jym77 Jym77 self-assigned this Sep 21, 2023
@Jym77 Jym77 added the patch Backwards-compatible change that doesn't touch public API label Sep 21, 2023
@Jym77 Jym77 marked this pull request as ready for review September 21, 2023 13:24
@Jym77 Jym77 requested review from a team and rcj-siteimprove September 21, 2023 13:24
@Jym77 Jym77 enabled auto-merge September 21, 2023 13:25
@Jym77 Jym77 added this pull request to the merge queue Sep 26, 2023
Merged via the queue into main with commit 0337ca8 Sep 26, 2023
6 checks passed
@Jym77 Jym77 deleted the buttonface branch September 26, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Backwards-compatible change that doesn't touch public API
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants