Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculatable image #1477

Merged
merged 22 commits into from
Oct 12, 2023
Merged

Calculatable image #1477

merged 22 commits into from
Oct 12, 2023

Conversation

Jym77
Copy link
Contributor

@Jym77 Jym77 commented Oct 11, 2023

Part of #1202

Rework the file structure of CSS gradients, modernize code, make them calculatable, add some tests.

@Jym77 Jym77 self-assigned this Oct 11, 2023
@Jym77 Jym77 added the major Backwards-incompatible change that touches public API label Oct 11, 2023

import { Position } from "./position";

const { map, either, option, right } = Parser;

Check notice

Code scanning / CodeQL

Unused variable, import, function or class

Unused variable either.
@Jym77
Copy link
Contributor Author

Jym77 commented Oct 11, 2023

!pr extract

@Jym77 Jym77 marked this pull request as ready for review October 11, 2023 12:22
@Jym77 Jym77 requested review from a team and rcj-siteimprove October 11, 2023 12:22
Copy link
Contributor

@rcj-siteimprove rcj-siteimprove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@Jym77 Jym77 added this pull request to the merge queue Oct 12, 2023
Merged via the queue into main with commit b0d3e07 Oct 12, 2023
@Jym77 Jym77 deleted the calculatable-image branch October 12, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major Backwards-incompatible change that touches public API
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants