Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calculatable shape #1478

Merged
merged 21 commits into from
Oct 18, 2023
Merged

Calculatable shape #1478

merged 21 commits into from
Oct 18, 2023

Conversation

Jym77
Copy link
Contributor

@Jym77 Jym77 commented Oct 13, 2023 •
edited
Loading

Part of #1202

Make Shape calculatable.
Clean the dirty hacks on Position that were introduced temporarily in #1454.

@Jym77 Jym77 self-assigned this Oct 13, 2023
@Jym77
Copy link
Contributor Author

Jym77 commented Oct 16, 2023

!pr extract

@Jym77 Jym77 added the major Backwards-incompatible change that touches public API label Oct 16, 2023
@Jym77
Copy link
Contributor Author

Jym77 commented Oct 16, 2023

!pr extract

@Jym77 Jym77 marked this pull request as ready for review October 16, 2023 09:32
@Jym77 Jym77 requested review from a team and rcj-siteimprove October 16, 2023 09:32
@Jym77
Copy link
Contributor Author

Jym77 commented Oct 18, 2023

!pr extract

rcj-siteimprove
rcj-siteimprove approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@rcj-siteimprove rcj-siteimprove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@Jym77 Jym77 added this pull request to the merge queue Oct 18, 2023
Merged via the queue into main with commit 1e266eb Oct 18, 2023
6 checks passed
@Jym77 Jym77 deleted the calculatable-shape branch October 18, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcj-siteimprove rcj-siteimprove rcj-siteimprove approved these changes

Assignees

@Jym77 Jym77

Labels
major Backwards-incompatible change that touches public API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jym77 @rcj-siteimprove