Clone-replace for alfa-dom Nodes
#1523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!pr extract |
rcj-siteimprove
added
the
minor
Jym77
requested changes
Dec 4, 2023
Jym77
reviewed
Dec 5, 2023
|
!pr extract |
|
!pr extract |
|
Ready for re-review, though still with a few un-resolved comments that could perhaps be split into new tasks, if they are non-blocking for this. |
Jym77
requested changes
Dec 7, 2023
|
!pr extract |
Jym77
previously approved these changes
Dec 7, 2023
Jym77
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduce new functions for cloning a DOM-tree with the option of replacing elements based on a predicate. A clone will be a new instance structurally equal to the original, but physically different.
The main use case is for a situation where we want to audit a document with some elements replaced to see how the modification impacts the result and since trees in Alfa are immutable, we do that by cloning and replacing.