Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor @siteimprove/alfa-media #1542

Merged
merged 16 commits into from
Jan 2, 2024
Merged

Refactor @siteimprove/alfa-media #1542

merged 16 commits into from
Jan 2, 2024

Conversation

Jym77
Copy link
Contributor

@Jym77 Jym77 commented Dec 22, 2023

  • Break down huge file into related components.
  • Refactor and streamline parsers.
  • Test haven't been touched.

@Jym77 Jym77 self-assigned this Dec 22, 2023
@Jym77 Jym77 added the internal Change that only affects internal APIs or other non-public aspects label Dec 22, 2023
@Jym77
Copy link
Contributor Author

Jym77 commented Dec 22, 2023

!pr extract

@Jym77 Jym77 marked this pull request as ready for review December 22, 2023 14:24
@Jym77 Jym77 requested a review from a team as a code owner December 22, 2023 14:24
@Jym77 Jym77 enabled auto-merge December 22, 2023 14:24
rcj-siteimprove
rcj-siteimprove approved these changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@rcj-siteimprove rcj-siteimprove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏼

@Jym77 Jym77 added this pull request to the merge queue Jan 2, 2024
Merged via the queue into main with commit b334aba Jan 2, 2024
6 checks passed
@Jym77 Jym77 deleted the refactor-alfa-media branch January 2, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcj-siteimprove rcj-siteimprove rcj-siteimprove approved these changes

Assignees

@Jym77 Jym77

Labels
internal Change that only affects internal APIs or other non-public aspects
Projects
⚙️ Alfa Development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jym77 @rcj-siteimprove