Fix tree traversal of flat tree #1547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
rcj-siteimprove
previously approved these changes
Jan 9, 2024
|
!pr extract |
rcj-siteimprove
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug in tree traversal of flat tree for the rare case of comments being direct child of the shadow root.
We had an exception for elements and text to skip over the shadow root and return the host instead when querying the parent in the flat tree. This is correct because in the flat tree the shadow tree has been inserted by "merging" the host and the root. However, that exception was missing for comments, creating an issue in these cases.
Additionally fixed a missing tree traversal option in
getNodeBetween.