Expose ariaAllowedAttributes on ARIA Element

[srnjcbsn]

The logic is moved from R18 implementation and made public.

Should we also have a prohibitedAttributes() function on the Element type, for symmetry?

[changeset-bot]

🦋 Changeset detected

Latest commit: 4701841

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 78 packages

Name	Type
@siteimprove/alfa-rules	Minor
@siteimprove/alfa-aria	Minor
@siteimprove/alfa-act	Minor
@siteimprove/alfa-affine	Minor
@siteimprove/alfa-applicative	Minor
@siteimprove/alfa-array	Minor
@siteimprove/alfa-bits	Minor
@siteimprove/alfa-branched	Minor
@siteimprove/alfa-cache	Minor
@siteimprove/alfa-callback	Minor
@siteimprove/alfa-cascade	Minor
@siteimprove/alfa-clone	Minor
@siteimprove/alfa-collection	Minor
@siteimprove/alfa-comparable	Minor
@siteimprove/alfa-compatibility	Minor
@siteimprove/alfa-continuation	Minor
@siteimprove/alfa-css-feature	Minor
@siteimprove/alfa-css	Minor
@siteimprove/alfa-device	Minor
@siteimprove/alfa-dom	Minor
@siteimprove/alfa-earl	Minor
@siteimprove/alfa-either	Minor
@siteimprove/alfa-emitter	Minor
@siteimprove/alfa-encoding	Minor
@siteimprove/alfa-equatable	Minor
@siteimprove/alfa-flags	Minor
@siteimprove/alfa-fnv	Minor
@siteimprove/alfa-foldable	Minor
@siteimprove/alfa-functor	Minor
@siteimprove/alfa-future	Minor
@siteimprove/alfa-generator	Minor
@siteimprove/alfa-graph	Minor
@siteimprove/alfa-hash	Minor
@siteimprove/alfa-http	Minor
@siteimprove/alfa-iana	Minor
@siteimprove/alfa-iterable	Minor
@siteimprove/alfa-json-ld	Minor
@siteimprove/alfa-json	Minor
@siteimprove/alfa-lazy	Minor
@siteimprove/alfa-list	Minor
@siteimprove/alfa-map	Minor
@siteimprove/alfa-mapper	Minor
@siteimprove/alfa-math	Minor
@siteimprove/alfa-monad	Minor
@siteimprove/alfa-network	Minor
@siteimprove/alfa-option	Minor
@siteimprove/alfa-parser	Minor
@siteimprove/alfa-performance	Minor
@siteimprove/alfa-predicate	Minor
@siteimprove/alfa-promise	Minor
@siteimprove/alfa-record	Minor
@siteimprove/alfa-rectangle	Minor
@siteimprove/alfa-reducer	Minor
@siteimprove/alfa-refinement	Minor
@siteimprove/alfa-result	Minor
@siteimprove/alfa-sarif	Minor
@siteimprove/alfa-selective	Minor
@siteimprove/alfa-selector	Minor
@siteimprove/alfa-sequence	Minor
@siteimprove/alfa-set	Minor
@siteimprove/alfa-slice	Minor
@siteimprove/alfa-string	Minor
@siteimprove/alfa-style	Minor
@siteimprove/alfa-table	Minor
@siteimprove/alfa-test-deprecated	Minor
@siteimprove/alfa-test	Minor
@siteimprove/alfa-thenable	Minor
@siteimprove/alfa-thunk	Minor
@siteimprove/alfa-time	Minor
@siteimprove/alfa-toolchain	Minor
@siteimprove/alfa-trampoline	Minor
@siteimprove/alfa-tree	Minor
@siteimprove/alfa-trilean	Minor
@siteimprove/alfa-tuple	Minor
@siteimprove/alfa-url	Minor
@siteimprove/alfa-wcag	Minor
@siteimprove/alfa-web	Minor
@siteimprove/alfa-xpath	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[Jym77]

Looks great. A few nitpicking code style comments.

[Jym77]

Should we also have a prohibitedAttributes() function on the Element type, for symmetry?

No. YAGNI. We'll move it when we need it…

[Jym77]

The Integrate workflows fails because it detects change in the API (the new method) that has not been registered in the docs.

You can extract the new API by using yarn extract packages/alfa-aria and committing the changed file. It can also be done automagically from the PR by commenting !pr extract (note do not push before that workflow ends, or it will fail to push its results…) I'll do that in the next comment.

[Jym77]

!pr extract

[srnjcbsn]

The Integrate workflows fails because it detects change in the API (the new method) that has not been registered in the docs.

You can extract the new API by using yarn extract packages/alfa-aria and committing the changed file. It can also be done automagically from the PR by commenting !pr extract (note do not push before that workflow ends, or it will fail to push its results…) I'll do that in the next comment.

I ran it locally and force pushed approximately when you were writing that comment, I think (hadn't noticed you had started reviewing, so I thought I could sneak it in)