2D 物理演算で三角形・四角形・ポリゴン・線分などの形状のセンサーを作れるように変更 #1251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ありがとうございます。確認します。 |
Reputeless
requested changes
Aug 7, 2024
|
上記以外は LGTM なので、修正完了次第 v0.6.16 へマージしたいと思います！ |
|
ありがとうございます。 |
Reputeless
approved these changes
Aug 8, 2024
|
Merged. Well done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
新しくフォークし直して再度コミットしました。
以下前回のプルリクエストと同文です。
2D 物理演算で円形以外の形状のセンサーを作れるように変更を加えました。
P2RectやP2Triangleなどのコンストラクタの引数にbool isSensorを加えています。P2BodyやP2WorldなどにaddRectSensor()やcreateRectSensor()などのセンサーを作る関数を加えています。P2World::createCircle()にオーバーロードが 2 つ存在しているので、それに合わせてP2World::createCircleSensor()も新たに 1 つオーバーロードを加えました。次のコードで動作を確認しました。
https://gist.github.com/Aikawa3311/a8bc38cc4667f5d93b3378ef402df276