Skip to content

Merge pull request #365 from SixLabors/js/fix-363 #895

Merge pull request #365 from SixLabors/js/fix-363

Merge pull request #365 from SixLabors/js/fix-363 #895

Triggered via push November 30, 2023 12:06
Status Success
Total duration 7m 51s
Artifacts
Matrix: Build
Fit to window
Zoom out
Zoom in

Annotations

70 warnings
Build (false, ubuntu-latest, net7.0, 7.0.x, true, -x64, false): tests/SixLabors.Fonts.Benchmarks/SixLabors.Fonts.Benchmarks/MeasureTextBenchmark.cs#L37
Change MeasureTextBenchmark.Dispose() to call GC.SuppressFinalize(object). This will prevent derived types that introduce a finalizer from needing to re-implement 'IDisposable' to call it. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1816)
Build (false, ubuntu-latest, net7.0, 7.0.x, true, -x64, false): tests/SixLabors.Fonts.Benchmarks/SixLabors.Fonts.Benchmarks/MeasureTextBenchmark.cs#L30
The behavior of 'SystemFonts.Get(string)' could vary based on the current user's locale settings. Replace this call in 'MeasureTextBenchmark.MeasureTextBenchmark()' with a call to 'SystemFonts.Get(string, CultureInfo)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1304)
Build (false, ubuntu-latest, net7.0, 7.0.x, true, -x64, false): tests/SixLabors.Fonts.Benchmarks/SixLabors.Fonts.Benchmarks/Program.cs#L8
Type 'Program' can be sealed because it has no subtypes in its containing assembly and is not externally visible (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1852)
Build (false, ubuntu-latest, net7.0, 7.0.x, true, -x64, false): samples/DrawWithImageSharp/Program.cs#L24
The behavior of 'FontCollection.Add(string)' could vary based on the current user's locale settings. Replace this call in 'Program.Main(string[])' with a call to 'FontCollection.Add(string, CultureInfo)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1304)
Build (false, ubuntu-latest, net7.0, 7.0.x, true, -x64, false): samples/DrawWithImageSharp/Program.cs#L25
The behavior of 'FontCollection.Add(string)' could vary based on the current user's locale settings. Replace this call in 'Program.Main(string[])' with a call to 'FontCollection.Add(string, CultureInfo)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1304)
Build (false, ubuntu-latest, net7.0, 7.0.x, true, -x64, false): samples/DrawWithImageSharp/Program.cs#L26
The behavior of 'FontCollection.Add(string)' could vary based on the current user's locale settings. Replace this call in 'Program.Main(string[])' with a call to 'FontCollection.Add(string, CultureInfo)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1304)
Build (false, ubuntu-latest, net7.0, 7.0.x, true, -x64, false): samples/DrawWithImageSharp/Program.cs#L27
The behavior of 'FontCollection.Add(string)' could vary based on the current user's locale settings. Replace this call in 'Program.Main(string[])' with a call to 'FontCollection.Add(string, CultureInfo)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1304)
Build (false, ubuntu-latest, net7.0, 7.0.x, true, -x64, false): samples/DrawWithImageSharp/Program.cs#L28
The behavior of 'FontCollection.Add(string)' could vary based on the current user's locale settings. Replace this call in 'Program.Main(string[])' with a call to 'FontCollection.Add(string, CultureInfo)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1304)
Build (false, ubuntu-latest, net7.0, 7.0.x, true, -x64, false): samples/DrawWithImageSharp/Program.cs#L29
The behavior of 'FontCollection.Add(string)' could vary based on the current user's locale settings. Replace this call in 'Program.Main(string[])' with a call to 'FontCollection.Add(string, CultureInfo)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1304)
Build (false, macos-latest, net6.0, 6.0.x, -x64, false): tests/SixLabors.Fonts.Benchmarks/SixLabors.Fonts.Benchmarks/MeasureTextBenchmark.cs#L37
Change MeasureTextBenchmark.Dispose() to call GC.SuppressFinalize(object). This will prevent derived types that introduce a finalizer from needing to re-implement 'IDisposable' to call it. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1816)
Build (false, macos-latest, net6.0, 6.0.x, -x64, false): tests/SixLabors.Fonts.Benchmarks/SixLabors.Fonts.Benchmarks/MeasureTextBenchmark.cs#L30
The behavior of 'SystemFonts.Get(string)' could vary based on the current user's locale settings. Replace this call in 'MeasureTextBenchmark.MeasureTextBenchmark()' with a call to 'SystemFonts.Get(string, CultureInfo)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1304)
Build (false, macos-latest, net6.0, 6.0.x, -x64, false): samples/DrawWithImageSharp/Program.cs#L24
The behavior of 'FontCollection.Add(string)' could vary based on the current user's locale settings. Replace this call in 'Program.Main(string[])' with a call to 'FontCollection.Add(string, CultureInfo)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1304)
Build (false, macos-latest, net6.0, 6.0.x, -x64, false): samples/DrawWithImageSharp/Program.cs#L25
The behavior of 'FontCollection.Add(string)' could vary based on the current user's locale settings. Replace this call in 'Program.Main(string[])' with a call to 'FontCollection.Add(string, CultureInfo)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1304)
Build (false, macos-latest, net6.0, 6.0.x, -x64, false): samples/DrawWithImageSharp/Program.cs#L26
The behavior of 'FontCollection.Add(string)' could vary based on the current user's locale settings. Replace this call in 'Program.Main(string[])' with a call to 'FontCollection.Add(string, CultureInfo)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1304)
Build (false, macos-latest, net6.0, 6.0.x, -x64, false): samples/DrawWithImageSharp/Program.cs#L27
The behavior of 'FontCollection.Add(string)' could vary based on the current user's locale settings. Replace this call in 'Program.Main(string[])' with a call to 'FontCollection.Add(string, CultureInfo)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1304)
Build (false, macos-latest, net6.0, 6.0.x, -x64, false): samples/DrawWithImageSharp/Program.cs#L28
The behavior of 'FontCollection.Add(string)' could vary based on the current user's locale settings. Replace this call in 'Program.Main(string[])' with a call to 'FontCollection.Add(string, CultureInfo)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1304)
Build (false, macos-latest, net6.0, 6.0.x, -x64, false): samples/DrawWithImageSharp/Program.cs#L29
The behavior of 'FontCollection.Add(string)' could vary based on the current user's locale settings. Replace this call in 'Program.Main(string[])' with a call to 'FontCollection.Add(string, CultureInfo)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1304)
Build (false, macos-latest, net6.0, 6.0.x, -x64, false): samples/DrawWithImageSharp/Program.cs#L30
The behavior of 'FontCollection.Add(string)' could vary based on the current user's locale settings. Replace this call in 'Program.Main(string[])' with a call to 'FontCollection.Add(string, CultureInfo)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1304)
Build (false, macos-latest, net7.0, 7.0.x, true, -x64, false): samples/DrawWithImageSharp/Program.cs#L305
Specify a culture or use an invariant version to avoid implicit dependency on current culture (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1311)
Build (false, macos-latest, net7.0, 7.0.x, true, -x64, false): samples/DrawWithImageSharp/Program.cs#L306
Specify a culture or use an invariant version to avoid implicit dependency on current culture (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1311)
Build (false, macos-latest, net7.0, 7.0.x, true, -x64, false): samples/DrawWithImageSharp/Program.cs#L305
The behavior of 'string.ToLower()' could vary based on the current user's locale settings. Replace this call in 'Program.RenderTextProcessorWithAlignment(FontFamily, string,
Build (false, macos-latest, net7.0, 7.0.x, true, -x64, false): samples/DrawWithImageSharp/Program.cs#L306
The behavior of 'string.ToLower()' could vary based on the current user's locale settings. Replace this call in 'Program.RenderTextProcessorWithAlignment(FontFamily, string,
Build (false, macos-latest, net7.0, 7.0.x, true, -x64, false): samples/DrawWithImageSharp/Program.cs#L350
'SaveImage' calls 'Aggregate' but does not use the value the method returns. Linq methods are known to not have side effects. Use the result in a conditional statement, assign the result to a variable, or pass it as an argument to another method. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1806)
Build (false, macos-latest, net7.0, 7.0.x, true, -x64, false): samples/DrawWithImageSharp/Program.cs#L24
The behavior of 'FontCollection.Add(string)' could vary based on the current user's locale settings. Replace this call in 'Program.Main(string[])' with a call to 'FontCollection.Add(string, CultureInfo)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1304)
Build (false, macos-latest, net7.0, 7.0.x, true, -x64, false): samples/DrawWithImageSharp/Program.cs#L25
The behavior of 'FontCollection.Add(string)' could vary based on the current user's locale settings. Replace this call in 'Program.Main(string[])' with a call to 'FontCollection.Add(string, CultureInfo)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1304)
Build (false, macos-latest, net7.0, 7.0.x, true, -x64, false): samples/DrawWithImageSharp/Program.cs#L26
The behavior of 'FontCollection.Add(string)' could vary based on the current user's locale settings. Replace this call in 'Program.Main(string[])' with a call to 'FontCollection.Add(string, CultureInfo)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1304)
Build (false, windows-latest, net6.0, 6.0.x, -x64, true): tests/SixLabors.Fonts.Tests/TestEnvironment.cs#L25
'Assembly.CodeBase' is obsolete: 'Assembly.CodeBase and Assembly.EscapedCodeBase are only included for .NET Framework compatibility. Use Assembly.Location.' (https://aka.ms/dotnet-warnings/SYSLIB0012)
Build (false, windows-latest, net6.0, 6.0.x, -x64, true): tests/SixLabors.Fonts.Tests/TestFonts.cs#L301
'Assembly.CodeBase' is obsolete: 'Assembly.CodeBase and Assembly.EscapedCodeBase are only included for .NET Framework compatibility. Use Assembly.Location.' (https://aka.ms/dotnet-warnings/SYSLIB0012)
Build (false, windows-latest, net6.0, 6.0.x, -x64, true): tests/SixLabors.Fonts.Tests/TextLayoutTests.cs#L780
Non-constant fields should not be visible (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2211)
Build (false, windows-latest, net6.0, 6.0.x, -x64, true): tests/SixLabors.Fonts.Tests/TextLayoutTests.cs#L1001
Non-constant fields should not be visible (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2211)
Build (false, windows-latest, net6.0, 6.0.x, -x64, true): tests/SixLabors.Fonts.Tests/WriterExtensions.cs#L625
Member 'LayerSize' does not access instance data and can be marked as static (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822)
Build (false, windows-latest, net6.0, 6.0.x, -x64, true): tests/SixLabors.Fonts.Tests/WriterExtensions.cs#L614
Member 'HeaderSize' does not access instance data and can be marked as static (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822)
Build (false, windows-latest, net6.0, 6.0.x, -x64, true): tests/SixLabors.Fonts.Tests/BigEndianBinaryWriter.cs#L35
Use nameof in place of string literal 'stream' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1507)
Build (false, windows-latest, net6.0, 6.0.x, -x64, true): tests/SixLabors.Fonts.Tests/BigEndianBinaryWriter.cs#L40
Use nameof in place of string literal 'stream' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1507)
Build (false, windows-latest, net6.0, 6.0.x, -x64, true): tests/SixLabors.Fonts.Tests/GlyphRenderer.cs#L21
In member bool GlyphRenderer.BeginGlyph(in FontRectangle rect, in GlyphRendererParameters parameters), change parameter name rect to bounds in order to match the identifier as it has been declared in bool IGlyphRenderer.BeginGlyph(in FontRectangle bounds, in GlyphRendererParameters parameters) (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1725)
Build (false, windows-latest, net6.0, 6.0.x, -x64, true): samples/DrawWithImageSharp/Program.cs#L305
The behavior of 'string.ToLower()' could vary based on the current user's locale settings. Replace this call in 'Program.RenderTextProcessorWithAlignment(FontFamily, string,
Build (false, windows-latest, net6.0, 6.0.x, -x64, true): samples/DrawWithImageSharp/Program.cs#L306
The behavior of 'string.ToLower()' could vary based on the current user's locale settings. Replace this call in 'Program.RenderTextProcessorWithAlignment(FontFamily, string,
Build (false, windows-latest, net6.0, 6.0.x, -x64, true): samples/DrawWithImageSharp/Program.cs#L350
'SaveImage' calls 'Aggregate' but does not use the value the method returns. Linq methods are known to not have side effects. Use the result in a conditional statement, assign the result to a variable, or pass it as an argument to another method. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1806)
Build (false, windows-latest, net6.0, 6.0.x, -x64, true): samples/DrawWithImageSharp/Program.cs#L24
The behavior of 'FontCollection.Add(string)' could vary based on the current user's locale settings. Replace this call in 'Program.Main(string[])' with a call to 'FontCollection.Add(string, CultureInfo)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1304)
Build (false, windows-latest, net6.0, 6.0.x, -x64, true): samples/DrawWithImageSharp/Program.cs#L25
The behavior of 'FontCollection.Add(string)' could vary based on the current user's locale settings. Replace this call in 'Program.Main(string[])' with a call to 'FontCollection.Add(string, CultureInfo)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1304)
Build (false, windows-latest, net6.0, 6.0.x, -x64, true): samples/DrawWithImageSharp/Program.cs#L26
The behavior of 'FontCollection.Add(string)' could vary based on the current user's locale settings. Replace this call in 'Program.Main(string[])' with a call to 'FontCollection.Add(string, CultureInfo)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1304)
Build (false, windows-latest, net6.0, 6.0.x, -x64, true): samples/DrawWithImageSharp/Program.cs#L27
The behavior of 'FontCollection.Add(string)' could vary based on the current user's locale settings. Replace this call in 'Program.Main(string[])' with a call to 'FontCollection.Add(string, CultureInfo)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1304)
Build (false, windows-latest, net7.0, 7.0.x, true, -x64, false): tests/SixLabors.Fonts.Benchmarks/SixLabors.Fonts.Benchmarks/MeasureTextBenchmark.cs#L30
The behavior of 'SystemFonts.Get(string)' could vary based on the current user's locale settings. Replace this call in 'MeasureTextBenchmark.MeasureTextBenchmark()' with a call to 'SystemFonts.Get(string, CultureInfo)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1304)
Build (false, windows-latest, net7.0, 7.0.x, true, -x64, false): tests/SixLabors.Fonts.Benchmarks/SixLabors.Fonts.Benchmarks/MeasureTextBenchmark.cs#L37
Change MeasureTextBenchmark.Dispose() to call GC.SuppressFinalize(object). This will prevent derived types that introduce a finalizer from needing to re-implement 'IDisposable' to call it. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1816)
Build (false, windows-latest, net7.0, 7.0.x, true, -x64, false): tests/SixLabors.Fonts.Benchmarks/SixLabors.Fonts.Benchmarks/Program.cs#L8
Type 'Program' can be sealed because it has no subtypes in its containing assembly and is not externally visible (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1852)
Build (false, windows-latest, net7.0, 7.0.x, true, -x64, false): samples/DrawWithImageSharp/Program.cs#L305
Specify a culture or use an invariant version to avoid implicit dependency on current culture (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1311)
Build (false, windows-latest, net7.0, 7.0.x, true, -x64, false): samples/DrawWithImageSharp/Program.cs#L306
Specify a culture or use an invariant version to avoid implicit dependency on current culture (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1311)
Build (false, windows-latest, net7.0, 7.0.x, true, -x64, false): samples/DrawWithImageSharp/Program.cs#L305
The behavior of 'string.ToLower()' could vary based on the current user's locale settings. Replace this call in 'Program.RenderTextProcessorWithAlignment(FontFamily, string,
Build (false, windows-latest, net7.0, 7.0.x, true, -x64, false): samples/DrawWithImageSharp/Program.cs#L306
The behavior of 'string.ToLower()' could vary based on the current user's locale settings. Replace this call in 'Program.RenderTextProcessorWithAlignment(FontFamily, string,
Build (false, windows-latest, net7.0, 7.0.x, true, -x64, false): samples/DrawWithImageSharp/Program.cs#L24
The behavior of 'FontCollection.Add(string)' could vary based on the current user's locale settings. Replace this call in 'Program.Main(string[])' with a call to 'FontCollection.Add(string, CultureInfo)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1304)
Build (false, ubuntu-latest, net6.0, 6.0.x, -x64, false): tests/SixLabors.Fonts.Benchmarks/SixLabors.Fonts.Benchmarks/MeasureTextBenchmark.cs#L37
Change MeasureTextBenchmark.Dispose() to call GC.SuppressFinalize(object). This will prevent derived types that introduce a finalizer from needing to re-implement 'IDisposable' to call it. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1816)
Build (false, ubuntu-latest, net6.0, 6.0.x, -x64, false): tests/SixLabors.Fonts.Benchmarks/SixLabors.Fonts.Benchmarks/MeasureTextBenchmark.cs#L30
The behavior of 'SystemFonts.Get(string)' could vary based on the current user's locale settings. Replace this call in 'MeasureTextBenchmark.MeasureTextBenchmark()' with a call to 'SystemFonts.Get(string, CultureInfo)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1304)
Build (false, ubuntu-latest, net6.0, 6.0.x, -x64, false): samples/DrawWithImageSharp/Program.cs#L24
The behavior of 'FontCollection.Add(string)' could vary based on the current user's locale settings. Replace this call in 'Program.Main(string[])' with a call to 'FontCollection.Add(string, CultureInfo)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1304)
Build (false, ubuntu-latest, net6.0, 6.0.x, -x64, false): samples/DrawWithImageSharp/Program.cs#L25
The behavior of 'FontCollection.Add(string)' could vary based on the current user's locale settings. Replace this call in 'Program.Main(string[])' with a call to 'FontCollection.Add(string, CultureInfo)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1304)
Build (false, ubuntu-latest, net6.0, 6.0.x, -x64, false): samples/DrawWithImageSharp/Program.cs#L26
The behavior of 'FontCollection.Add(string)' could vary based on the current user's locale settings. Replace this call in 'Program.Main(string[])' with a call to 'FontCollection.Add(string, CultureInfo)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1304)
Build (false, ubuntu-latest, net6.0, 6.0.x, -x64, false): samples/DrawWithImageSharp/Program.cs#L27
The behavior of 'FontCollection.Add(string)' could vary based on the current user's locale settings. Replace this call in 'Program.Main(string[])' with a call to 'FontCollection.Add(string, CultureInfo)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1304)
Build (false, ubuntu-latest, net6.0, 6.0.x, -x64, false): samples/DrawWithImageSharp/Program.cs#L28
The behavior of 'FontCollection.Add(string)' could vary based on the current user's locale settings. Replace this call in 'Program.Main(string[])' with a call to 'FontCollection.Add(string, CultureInfo)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1304)
Build (false, ubuntu-latest, net6.0, 6.0.x, -x64, false): samples/DrawWithImageSharp/Program.cs#L29
The behavior of 'FontCollection.Add(string)' could vary based on the current user's locale settings. Replace this call in 'Program.Main(string[])' with a call to 'FontCollection.Add(string, CultureInfo)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1304)
Build (false, ubuntu-latest, net6.0, 6.0.x, -x64, false): samples/DrawWithImageSharp/Program.cs#L30
The behavior of 'FontCollection.Add(string)' could vary based on the current user's locale settings. Replace this call in 'Program.Main(string[])' with a call to 'FontCollection.Add(string, CultureInfo)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1304)