Merge pull request #409 from Bykiev/FixMemoryLeak

Fix memory leak in VerticalMetricsTable
SixLabors · Aug 1, 2024 · 165a348 · 165a348
2 parents 92a4f32 + baca1eb
commit 165a348
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/SixLabors.Fonts/BigEndianBinaryReader.cs b/src/SixLabors.Fonts/BigEndianBinaryReader.cs
@@ -12,7 +12,7 @@ namespace SixLabors.Fonts;
 /// BinaryReader using big-endian encoding.
 /// </summary>
 [DebuggerDisplay("Start: {StartOfStream}, Position: {BaseStream.Position}")]
-internal class BigEndianBinaryReader : IDisposable
+internal sealed class BigEndianBinaryReader : IDisposable
 {
     /// <summary>
     /// Buffer used for temporary storage before conversion into primitives

diff --git a/src/SixLabors.Fonts/Tables/General/VerticalMetricsTable.cs b/src/SixLabors.Fonts/Tables/General/VerticalMetricsTable.cs
@@ -47,7 +47,10 @@ internal short GetTopSideBearing(int glyphIndex)
             return null;
         }
 
-        return Load(binaryReader, headTable.NumberOfVMetrics, profileTable.GlyphCount);
+        using (binaryReader)
+        {
+            return Load(binaryReader, headTable.NumberOfVMetrics, profileTable.GlyphCount);
+        }
     }
 
     public static VerticalMetricsTable Load(BigEndianBinaryReader reader, int metricCount, int glyphCount)