Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve color profile when encoding bitmaps #2108

Merged
merged 5 commits into from
May 7, 2022
Merged

Preserve color profile when encoding bitmaps #2108

merged 5 commits into from
May 7, 2022

Conversation

brianpopow
Copy link
Collaborator

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

This PR changes the decoder to read the color profile when present and also the encoder to preserve it when encoding a bitmap.

Related to #2107

JimBobSquarePants
JimBobSquarePants approved these changes May 7, 2022
View reviewed changes
Copy link
Member

@JimBobSquarePants JimBobSquarePants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was fast! 🚀 👍

@JimBobSquarePants JimBobSquarePants added this to the 3.0.0 milestone May 7, 2022
@brianpopow brianpopow merged commit 2aa150c into main May 7, 2022
@brianpopow brianpopow deleted the bp/bmp-icc branch May 7, 2022 14:17
@brianpopow brianpopow mentioned this pull request May 12, 2022
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JimBobSquarePants JimBobSquarePants JimBobSquarePants approved these changes

Assignees
No one assigned
Labels
formats:bmp metadata:icc
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@brianpopow @JimBobSquarePants