Normalize Encoder Transparency Handling For Alpha Aware Image Formats #2844
+1,737
−847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JimBobSquarePants
added
enhancement
API
breaking
There was a problem hiding this comment.
Copilot reviewed 66 out of 81 changed files in this pull request and generated no suggestions.
Files not reviewed (15)
- src/ImageSharp/Formats/Png/PngTransparentColorMode.cs: Evaluated as low risk
- src/ImageSharp/Formats/Gif/GifEncoderCore.cs: Evaluated as low risk
- src/ImageSharp/Formats/Cur/CurFrameMetadata.cs: Evaluated as low risk
- src/ImageSharp/Formats/Gif/GifDecoderCore.cs: Evaluated as low risk
- src/ImageSharp/Formats/Pbm/BinaryEncoder.cs: Evaluated as low risk
- src/ImageSharp/Formats/Tga/TgaEncoder.cs: Evaluated as low risk
- src/ImageSharp/Formats/EncodingUtilities.cs: Evaluated as low risk
- src/ImageSharp/Formats/Tga/TgaEncoderCore.cs: Evaluated as low risk
- src/ImageSharp/Formats/Pbm/PlainEncoder.cs: Evaluated as low risk
- src/ImageSharp/Formats/Pbm/PbmEncoderCore.cs: Evaluated as low risk
- src/ImageSharp/Formats/Png/PngEncoder.cs: Evaluated as low risk
- src/ImageSharp/Formats/Qoi/QoiEncoder.cs: Evaluated as low risk
- src/ImageSharp/Formats/Icon/IconEncoderCore.cs: Evaluated as low risk
- src/ImageSharp/Formats/IQuantizingImageEncoder.cs: Evaluated as low risk
- src/ImageSharp/Formats/Png/PngEncoderCore.cs: Evaluated as low risk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
This PR adds a new abstract
AlphaAwareImageEncodertype which is used to normalize transparent color handling during encoding. Prior to this normalization both PNG and WEBP encoders had separate enum properties that used the same values and behavior. Now any encoder which belongs to an image format that is capable of encoding alpha data shares the same options and functionality.In addition:
ImageFrame.Boundswas normalized to a readonly property to matchImage