Add one more check

SizeCredit · Dec 4, 2023 · 3dc86b8 · 3dc86b8
1 parent 1cb1321
commit 3dc86b8
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/src/libraries/LoanLibrary.sol b/src/libraries/LoanLibrary.sol
@@ -64,10 +64,6 @@ library LoanLibrary {
         return isFOL(self) ? self.dueDate : loans[self.folId].dueDate;
     }
 
-    function getFOL(Loan memory self, Loan[] memory loans) public pure returns (Loan memory) {
-        return isFOL(self) ? self : loans[self.folId];
-    }
-
     function isOverdue(Loan memory self, Loan[] memory loans) public view returns (bool) {
         return block.timestamp >= getDueDate(self, loans);
     }
@@ -100,6 +96,7 @@ library LoanLibrary {
             })
         );
         if (FV > getCredit(fol)) {
+            // @audit this has 0 coverage, I believe it is already checked by _borrowWithVirtualCollateral & validateExit
             revert Errors.NOT_ENOUGH_FREE_CASH(getCredit(fol), FV);
         }
         fol.amountFVExited += FV;

diff --git a/test/BorrowAsMarketOrder.t.sol b/test/BorrowAsMarketOrder.t.sol
@@ -273,7 +273,6 @@ contract BorrowAsMarketOrderTest is BaseTest {
         _deposit(alice, usdc, 1000e6);
         _deposit(bob, weth, 1e18);
         _lendAsLimitOrder(alice, 100e18, 12, 0.03e4, 12);
-        LoanOffer memory offerBefore = size.getLoanOffer(alice);
 
         _withdraw(alice, usdc, 999e6);
 

diff --git a/test/LendAsLimitOrderValidation.t.sol b/test/LendAsLimitOrderValidation.t.sol
@@ -19,7 +19,7 @@ contract LendAsLimitOrderValidationTest is BaseTest {
     using OfferLibrary for LoanOffer;
 
     function test_LendAsLimitOrderValidation() public {
-        _deposit(alice, 100e18, 100e18);
+        _deposit(alice, address(usdc), 100e6);
         uint256 maxAmount = 100e18;
         uint256 maxDueDate = 12;
         uint256[] memory timeBuckets = new uint256[](2);
@@ -28,6 +28,7 @@ contract LendAsLimitOrderValidationTest is BaseTest {
         uint256[] memory rates1 = new uint256[](1);
         rates1[0] = 1.01e4;
 
+        vm.startPrank(alice);
         vm.expectRevert(abi.encodeWithSelector(Errors.ARRAY_LENGTHS_MISMATCH.selector));
         size.lendAsLimitOrder(maxAmount, maxDueDate, timeBuckets, rates1);
 
@@ -42,6 +43,9 @@ contract LendAsLimitOrderValidationTest is BaseTest {
         vm.expectRevert(abi.encodeWithSelector(Errors.NULL_AMOUNT.selector));
         size.lendAsLimitOrder(0, maxDueDate, timeBuckets, rates);
 
+        vm.expectRevert(abi.encodeWithSelector(Errors.NOT_ENOUGH_FREE_CASH.selector, 100e18, 100e18 + 1));
+        size.lendAsLimitOrder(maxAmount + 1, maxDueDate, timeBuckets, rates);
+
         vm.expectRevert(abi.encodeWithSelector(Errors.NULL_MAX_DUE_DATE.selector));
         size.lendAsLimitOrder(maxAmount, 0, timeBuckets, rates);