Fix reduceDebt and use it in SelfLiquidateLoan

SizeCredit · Jan 5, 2024 · be188d9 · be188d9
1 parent ec8ba6b
commit be188d9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 23 deletions.
diff --git a/src/libraries/actions/Common.sol b/src/libraries/actions/Common.sol
@@ -12,17 +12,15 @@ library Common {
 
     function reduceDebt(State storage state, uint256 loanId, uint256 amount) public {
         Loan storage loan = state.loans[loanId];
+        Loan storage fol = getFOL(state, loan);
         if (amount > loan.getCredit()) {
             revert Errors.NOT_ENOUGH_CREDIT(loan.getCredit(), amount);
         }
 
-        loan.faceValue -= amount;
+        state.tokens.debtToken.burn(fol.borrower, amount);
 
-        if (loan.isFOL()) {
-            // @audit Check this logic
-            state.tokens.debtToken.burn(loan.borrower, amount);
-        } else {
-            Loan storage fol = state.loans[loan.folId];
+        loan.faceValue -= amount;
+        if (!loan.isFOL()) {
             fol.faceValue -= amount;
             fol.faceValueExited -= amount;
         }

diff --git a/src/libraries/actions/SelfLiquidateLoan.sol b/src/libraries/actions/SelfLiquidateLoan.sol
@@ -58,22 +58,6 @@ library SelfLiquidateLoan {
 
         uint256 assignedCollateral = state.getProRataAssignedCollateral(params.loanId);
         state.tokens.collateralToken.transferFrom(fol.borrower, msg.sender, assignedCollateral);
-        state.tokens.debtToken.burn(fol.borrower, credit);
-
-        if (loan.isFOL()) {
-            // loan.faceValue := loan.faceValueExited
-            //                 = 0, if no exits
-            //                >= state.config.minimumCredit, if at least 1 exit
-            loan.faceValue -= credit;
-        } else {
-            // same
-            loan.faceValue -= credit;
-
-            // deducting faceValue and faceValueExited by the same amount does not change the credit,
-            //   since it is the difference between these two values
-            // so fol.getCredit() >= state.config.minimumCredit still
-            fol.faceValue -= credit;
-            fol.faceValueExited -= credit;
-        }
+        state.reduceDebt(params.loanId, credit);
     }
 }