Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

c4-021 Add borrower to RepayStruct to avoid MEV #141

Merged
merged 2 commits into from
Jul 15, 2024
Merged

c4-021 Add borrower to RepayStruct to avoid MEV #141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f08695f
c4-021 Add borrower to RepayStruct to avoid MEV
aviggiano Jul 9, 2024
01f0697
Fix typo
aviggiano Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/libraries/Errors.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ library Errors {
error INVALID_DEBT_POSITION_ID(uint256 debtPositionId);
error INVALID_CREDIT_POSITION_ID(uint256 creditPositionId);
error INVALID_LENDER(address account);
error INVALID_BORROWER(address account);
error INVALID_LOAN_OFFER(address lender);
error INVALID_BORROW_OFFER(address borrower);

Expand Down
6 changes: 6 additions & 0 deletions src/libraries/actions/Repay.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import {Events} from "@src/libraries/Events.sol";

struct RepayParams {
uint256 debtPositionId;
address borrower;
}

/// @title Repay
Expand All @@ -36,6 +37,11 @@ library Repay {
revert Errors.LOAN_ALREADY_REPAID(params.debtPositionId);
}

// validate borrower
if (state.getDebtPosition(params.debtPositionId).borrower != params.borrower) {
revert Errors.INVALID_BORROWER(params.borrower);
}

// validate msg.sender
// N/A
}
Expand Down
Loading