Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement discovering CRDs in git repositories directly #155

Merged
merged 11 commits into from
Jan 4, 2025

Conversation

Skarlso
Copy link
Owner

@Skarlso Skarlso commented Jan 1, 2025

Closes #154

@Skarlso Skarlso force-pushed the implement-discover-crds-from-git-url branch from d5d279a to 25474f5 Compare January 2, 2025 20:29
@Skarlso
Copy link
Owner Author

Skarlso commented Jan 3, 2025

It just dawned on my that the CORS server will be unable to start on the static github pages website 😭

@Skarlso
Copy link
Owner Author

Skarlso commented Jan 3, 2025

Actually, on the WEB, I can just plain download the ZIP file. HAH!

@Skarlso
Copy link
Owner Author

Skarlso commented Jan 3, 2025

Okay, this isn't going to work on the website. The codedownload is also behind a CORS protection, so that will not work either. And I won't use a cors proxy and I won't switch to a no WASM frontend. So... bye bye frontend support.

@Skarlso Skarlso marked this pull request as ready for review January 4, 2025 08:45
Signed-off-by: Gergely Brautigam <[email protected]>
@Skarlso Skarlso merged commit 6ad4fc0 into main Jan 4, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create integration for providing GitHub URLs and then discovering CRDs in the Repository
1 participant