Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QF-1000 Migrate from Newtonsoft.Json to System.Text.Json #360

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

QF-1000 Migrate from Newtonsoft.Json to System.Text.Json #360

wants to merge 10 commits into from

Conversation

SawNawDfE
Copy link
Contributor

No description provided.

@SawNawDfE SawNawDfE self-assigned this Feb 16, 2023
@das-github-app
Copy link

Please remember to check any packages used by this application to ensure they are up to date @SawNawDfE. cc/ @ecarroll95

ChrisJWoodcock
ChrisJWoodcock requested changes Feb 17, 2023
View reviewed changes
Copy link
Contributor

@ChrisJWoodcock ChrisJWoodcock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still seeing a few references to NewtonSoft.Json.Linq

@SawNawDfE
Copy link
Contributor Author

SawNawDfE commented Feb 17, 2023 •
edited
Loading

Still seeing a few references to NewtonSoft.Json.Linq

Update: These references no longer exist as of the latest commit

~~I've removed two of those 3 references. One was not being used, and the other needed a light refactor before being removed.

The last one in Application.cs will require some thought. I can guess what it's trying to do, but it's working with dynamic data and there aren't any unit tests I can rely on to guarantee that my refactors would be 1:1.~~

@ChrisJWoodcock

@das-github-app
Copy link

Please remember to check any packages used by this application to ensure they are up to date @SawNawDfE. cc/ @ecarroll95

@das-github-app
Copy link

Please remember to check any packages used by this application to ensure they are up to date @SawNawDfE. cc/ @ecarroll95

@das-github-app
Copy link

Please remember to check any packages used by this application to ensure they are up to date @SawNawDfE. cc/ @ecarroll95

@SawNawDfE
Copy link
Contributor Author

I've renamed the Web.Tests project file and folder to Web.UnitTests, so that they're detected and ran by the pipelines. The PR might interpret this as a large number of additions and deletions

@das-github-app
Copy link

Please remember to check any packages used by this application to ensure they are up to date @SawNawDfE. cc/ @ecarroll95

@das-github-app
Copy link

Please remember to check any packages used by this application to ensure they are up to date @SawNawDfE. cc/ @ecarroll95

@das-github-app
Copy link

Please remember to check any packages used by this application to ensure they are up to date @SawNawDfE. cc/ @ecarroll95

@das-github-app
Copy link

Please remember to check any packages used by this application to ensure they are up to date @SawNawDfE. cc/ @ecarroll95

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 46 Code Smells

0.0% 0.0% Coverage
0.5% 0.5% Duplication

@SawNawDfE SawNawDfE changed the title Migrate from Newtonsoft.Json to System.Text.Json QF-1000 Migrate from Newtonsoft.Json to System.Text.Json Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisJWoodcock ChrisJWoodcock ChrisJWoodcock approved these changes

@MarkFCain MarkFCain Awaiting requested review from MarkFCain

@alandburns alandburns Awaiting requested review from alandburns

@cofaulco cofaulco Awaiting requested review from cofaulco

@chrisfoster76 chrisfoster76 Awaiting requested review from chrisfoster76

@DevenKShah DevenKShah Awaiting requested review from DevenKShah

Assignees

@SawNawDfE SawNawDfE

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SawNawDfE @ChrisJWoodcock