Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QF-1262 Fix Major CSS issues reported on SonarCloud #371

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

QF-1262 Fix Major CSS issues reported on SonarCloud #371

wants to merge 3 commits into from

Conversation

SawNawDfE
Copy link
Contributor

@SawNawDfE SawNawDfE commented Apr 21, 2023 •
edited
Loading

  • Move the CSS in _ErrorPageLayout.cshtml into a separate file, so that both the Visual Studio compiler and SonarCloud can interpret it correctly.
  • Replace double @@ with single @ for CSS at-rules. This was confusing SonarCloud, which was flagging the double @@ as invalid at-rules.
  • Remove duplicate CSS properties by using only the last instance of a duplicate property, which is what modern browsers do by default.

Replace double @@ with single @ for CSS at-rules. Remove duplicate CS…
b323ba5 
…S properties by using only the last instance of a duplicate property, which is what modern browsers do by default.
@das-github-app
Copy link

Please remember to check any packages used by this application to ensure they are up to date @SawNawDfE. cc/ @ecarroll95

@das-github-app
Copy link

Please remember to check any packages used by this application to ensure they are up to date @SawNawDfE. cc/ @ecarroll95

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkFCain MarkFCain Awaiting requested review from MarkFCain

@alandburns alandburns Awaiting requested review from alandburns

@ChrisJWoodcock ChrisJWoodcock Awaiting requested review from ChrisJWoodcock ChrisJWoodcock is a code owner

@cofaulco cofaulco Awaiting requested review from cofaulco

@chrisfoster76 chrisfoster76 Awaiting requested review from chrisfoster76

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@SawNawDfE