remove duplicate healthcheck

SkillsFundingAgency · Feb 21, 2025 · 51e5911 · 51e5911
1 parent 695bc2b
commit 51e5911
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 12 deletions.
diff --git a/src/AdminAan/SFA.DAS.AdminAan.Api/AppStart/ServiceCollectionExtensions.cs b/src/AdminAan/SFA.DAS.AdminAan.Api/AppStart/ServiceCollectionExtensions.cs
@@ -91,9 +91,6 @@ public static IServiceCollection AddServiceHealthChecks(this IServiceCollection
             .AddCheck<CoursesApiHealthCheck>(CoursesApiHealthCheck.HealthCheckResultDescription,
                 failureStatus: HealthStatus.Unhealthy,
                 tags: [Ready])
-            .AddCheck<CoursesApiHealthCheck>(CoursesApiHealthCheck.HealthCheckResultDescription,
-                failureStatus: HealthStatus.Unhealthy,
-                tags: [Ready])
             .AddCheck<EducationalOrganisationApiHealthCheck>(EducationalOrganisationApiHealthCheck.HealthCheckResultDescription,
                 failureStatus: HealthStatus.Unhealthy,
                 tags: [Ready])

diff --git a/src/AdminAan/SFA.DAS.AdminAan.Api/HealthCheck/CoursesApiHealthCheck.cs b/src/AdminAan/SFA.DAS.AdminAan.Api/HealthCheck/CoursesApiHealthCheck.cs
@@ -3,20 +3,13 @@
 
 namespace SFA.DAS.AdminAan.Api.HealthCheck;
 
-public class CoursesApiHealthCheck : IHealthCheck
+public class CoursesApiHealthCheck(ICoursesApiClient coursesApiClient) : IHealthCheck
 {
     public const string HealthCheckResultDescription = "Courses API Health Check";
 
-    private readonly ICoursesApiClient _coursesApiClient;
-
-    public CoursesApiHealthCheck(ICoursesApiClient coursesApiClient)
-    {
-        _coursesApiClient = coursesApiClient;
-    }
-
     public async Task<HealthCheckResult> CheckHealthAsync(HealthCheckContext context, CancellationToken cancellationToken = new())
     {
-        var response = await _coursesApiClient.GetHealth(cancellationToken);
+        var response = await coursesApiClient.GetHealth(cancellationToken);
         return response.IsSuccessStatusCode
             ? HealthCheckResult.Healthy(HealthCheckResultDescription)
             : HealthCheckResult.Unhealthy(HealthCheckResultDescription);