-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FAI-2021 APIM Delete search alerts Dormant Account #1859
Open
balaji-j
wants to merge
8
commits into
master
Choose a base branch
from
FAI-2021_APIM_Delete_Search_Alerts_Dormant_Account
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
2a9cf3a
WIP
balaji-j ddf65ce
Endpoints added for getting the dormant candidates and Un-subscribe s…
balaji-j 266eefc
Make termsOfUseAcceptedOn datatype as nullable
balaji-j 2b13d4f
Update Candidate Status endpoint added
balaji-j ab228ee
Cleanup
balaji-j 6f4dc39
Added condition to activate the account if the user logins again
balaji-j 837926b
Merge branch 'master' into FAI-2021_APIM_Delete_Search_Alerts_Dormant…
balaji-j 8191c72
PR Comments addressed
balaji-j File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
56 changes: 56 additions & 0 deletions
56
...A.DAS.FindApprenticeshipJobs.Api.UnitTests/Controllers/WhenGettingCandidatesByActivity.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
using AutoFixture.NUnit3; | ||
using FluentAssertions; | ||
using FluentAssertions.Execution; | ||
using MediatR; | ||
using Microsoft.AspNetCore.Mvc; | ||
using Moq; | ||
using NUnit.Framework; | ||
using SFA.DAS.FindApprenticeshipJobs.Api.Controllers; | ||
using SFA.DAS.FindApprenticeshipJobs.Application.Queries.SavedSearch.GetCandidatesByActivity; | ||
using SFA.DAS.Testing.AutoFixture; | ||
using System.Net; | ||
|
||
namespace SFA.DAS.FindApprenticeshipJobs.Api.UnitTests.Controllers | ||
{ | ||
[TestFixture] | ||
public class WhenGettingCandidatesByActivity | ||
{ | ||
[Test, MoqAutoData] | ||
public async Task Then_Candidates_Returned_From_Mediator( | ||
int pageNumber, | ||
int pageSize, | ||
DateTime cutOffDateTime, | ||
GetCandidateByActivityQueryResult mockQueryResult, | ||
[Frozen] Mock<IMediator> mockMediator, | ||
[Greedy] CandidatesController sut) | ||
{ | ||
mockMediator.Setup(x => x.Send(It.IsAny<GetCandidateByActivityQuery>(), It.IsAny<CancellationToken>())).ReturnsAsync(mockQueryResult); | ||
|
||
var actual = await sut.GetCandidatesByActivity(cutOffDateTime, pageNumber, pageSize, It.IsAny<CancellationToken>()) as ObjectResult; | ||
var actualValue = actual!.Value as GetCandidateByActivityQueryResult; | ||
|
||
using (new AssertionScope()) | ||
{ | ||
actual.StatusCode.Should().Be((int)HttpStatusCode.OK); | ||
actual.Value.Should().BeOfType<GetCandidateByActivityQueryResult>(); | ||
actualValue!.Candidates.Should().BeEquivalentTo(mockQueryResult.Candidates); | ||
} | ||
} | ||
|
||
[Test, MoqAutoData] | ||
public async Task And_Exception_Returned_Then_Returns_Internal_Server_Error( | ||
int pageNumber, | ||
int pageSize, | ||
DateTime cutOffDateTime, | ||
GetCandidateByActivityQueryResult mockQueryResult, | ||
[Frozen] Mock<IMediator> mockMediator, | ||
[Greedy] CandidatesController sut) | ||
{ | ||
mockMediator.Setup(x => x.Send(It.IsAny<GetCandidateByActivityQuery>(), It.IsAny<CancellationToken>())).ThrowsAsync(new InvalidOperationException()); | ||
|
||
var actual = await sut.GetCandidatesByActivity(cutOffDateTime, pageNumber, pageSize, It.IsAny<CancellationToken>()) as StatusCodeResult; | ||
|
||
actual!.StatusCode.Should().Be((int)HttpStatusCode.InternalServerError); | ||
} | ||
} | ||
} |
52 changes: 52 additions & 0 deletions
52
...bs/SFA.DAS.FindApprenticeshipJobs.Api.UnitTests/Controllers/WhenPostingCandidateStatus.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
using AutoFixture.NUnit3; | ||
using FluentAssertions; | ||
using FluentAssertions.Execution; | ||
using MediatR; | ||
using Microsoft.AspNetCore.Mvc; | ||
using Moq; | ||
using NUnit.Framework; | ||
using SFA.DAS.FindApprenticeshipJobs.Api.Models; | ||
using SFA.DAS.FindApprenticeshipJobs.Application.Commands.Candidates; | ||
using SFA.DAS.Testing.AutoFixture; | ||
using System.Net; | ||
|
||
namespace SFA.DAS.FindApprenticeshipJobs.Api.UnitTests.Controllers | ||
{ | ||
[TestFixture] | ||
public class WhenPostingCandidateStatus | ||
{ | ||
[Test, MoqAutoData] | ||
public async Task Then_Returns_Post_Response( | ||
string govIdentifier, | ||
CandidateUpdateStatusRequest model, | ||
[Frozen] Mock<IMediator> mediator, | ||
[Greedy] Api.Controllers.CandidatesController controller) | ||
{ | ||
var actual = await controller.UpdateStatus(govIdentifier, model); | ||
|
||
using (new AssertionScope()) | ||
{ | ||
actual.Should().BeOfType<NoContentResult>(); | ||
} | ||
} | ||
|
||
[Test, MoqAutoData] | ||
public async Task Then_If_An_Exception_Is_Thrown_Then_Internal_Server_Error_Response_Returned( | ||
string govIdentifier, | ||
CandidateUpdateStatusRequest model, | ||
[Frozen] Mock<IMediator> mediator, | ||
[Greedy] Api.Controllers.CandidatesController controller) | ||
{ | ||
mediator.Setup(x => x.Send(It.Is<UpdateCandidateStatusCommand>(x => x.GovUkIdentifier == govIdentifier | ||
&& (x.Email == model.Email) | ||
&& x.Status == model.Status), | ||
It.IsAny<CancellationToken>())) | ||
.ThrowsAsync(new Exception()); | ||
|
||
var actual = await controller.UpdateStatus(govIdentifier, model) as StatusCodeResult; | ||
|
||
Assert.That(actual, Is.Not.Null); | ||
actual.StatusCode.Should().Be((int)HttpStatusCode.InternalServerError); | ||
} | ||
} | ||
} |
66 changes: 66 additions & 0 deletions
66
...ApprenticeshipJobs/SFA.DAS.FindApprenticeshipJobs.Api/Controllers/CandidatesController.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,66 @@ | ||
using MediatR; | ||
using Microsoft.AspNetCore.Mvc; | ||
using SFA.DAS.FindApprenticeshipJobs.Application.Queries.SavedSearch.GetCandidatesByActivity; | ||
using System.Net; | ||
using SFA.DAS.FindApprenticeshipJobs.Application.Commands.Candidates; | ||
using SFA.DAS.FindApprenticeshipJobs.Domain.Models; | ||
using SFA.DAS.FindApprenticeshipJobs.Api.Models; | ||
|
||
namespace SFA.DAS.FindApprenticeshipJobs.Api.Controllers | ||
{ | ||
[ApiController] | ||
[Route("[controller]")] | ||
public class CandidatesController( | ||
IMediator mediator, | ||
ILogger<CandidatesController> logger) : ControllerBase | ||
{ | ||
[HttpGet] | ||
[Route("GetCandidatesByActivity")] | ||
[ProducesResponseType((int)HttpStatusCode.OK)] | ||
[ProducesResponseType((int)HttpStatusCode.InternalServerError)] | ||
public async Task<IActionResult> GetCandidatesByActivity( | ||
[FromQuery] DateTime cutOffDateTime, | ||
[FromQuery] int pageNumber = 1, | ||
[FromQuery] int pageSize = 10, | ||
CancellationToken cancellationToken = default) | ||
{ | ||
logger.LogInformation("Get Candidates by activity invoked"); | ||
|
||
try | ||
{ | ||
var result = await mediator.Send(new GetCandidateByActivityQuery(cutOffDateTime, pageNumber, pageSize), | ||
cancellationToken); | ||
return Ok(result); | ||
} | ||
catch (Exception ex) | ||
{ | ||
logger.LogError(ex, "Error invoking Get Candidates By Activity"); | ||
return new StatusCodeResult((int)HttpStatusCode.InternalServerError); | ||
} | ||
} | ||
|
||
[HttpPost] | ||
[Route("{govIdentifier}/status")] | ||
public async Task<IActionResult> UpdateStatus( | ||
[FromRoute] string govIdentifier, | ||
[FromBody] CandidateUpdateStatusRequest request) | ||
{ | ||
try | ||
{ | ||
await mediator.Send(new UpdateCandidateStatusCommand | ||
{ | ||
GovUkIdentifier = govIdentifier, | ||
Email = request.Email, | ||
Status = request.Status | ||
}); | ||
|
||
return NoContent(); | ||
} | ||
catch (Exception e) | ||
{ | ||
logger.LogError(e, "Error attempting to update candidate status"); | ||
return StatusCode((int)HttpStatusCode.InternalServerError); | ||
} | ||
} | ||
} | ||
} |
10 changes: 10 additions & 0 deletions
10
...renticeshipJobs/SFA.DAS.FindApprenticeshipJobs.Api/Models/CandidateUpdateStatusRequest.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
using SFA.DAS.FindApprenticeshipJobs.Domain.Models; | ||
|
||
namespace SFA.DAS.FindApprenticeshipJobs.Api.Models | ||
{ | ||
public class CandidateUpdateStatusRequest | ||
{ | ||
public required string Email { get; set; } | ||
public UserStatus Status { get; set; } | ||
} | ||
} |
45 changes: 45 additions & 0 deletions
45
...S.FindApprenticeshipJobs.UnitTests/Candidates/WhenHandlingGetCandidatesByActivityQuery.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
using AutoFixture.NUnit3; | ||
using FluentAssertions; | ||
using Moq; | ||
using NUnit.Framework; | ||
using SFA.DAS.FindApprenticeshipJobs.Application.Queries.SavedSearch.GetCandidatesByActivity; | ||
using SFA.DAS.FindApprenticeshipJobs.InnerApi.Requests; | ||
using SFA.DAS.FindApprenticeshipJobs.InnerApi.Responses; | ||
using SFA.DAS.SharedOuterApi.Configuration; | ||
using SFA.DAS.SharedOuterApi.Interfaces; | ||
using SFA.DAS.Testing.AutoFixture; | ||
|
||
namespace SFA.DAS.FindApprenticeshipJobs.UnitTests.Candidates | ||
{ | ||
[TestFixture] | ||
public class WhenHandlingGetCandidatesByActivityQuery | ||
{ | ||
[Test] | ||
[MoqAutoData] | ||
public async Task Then_The_Candidates_Are_Returned( | ||
GetCandidateByActivityQuery query, | ||
GetCandidatesByActivityApiResponse mockCandidatesByActivityApiResponse, | ||
[Frozen] Mock<ICandidateApiClient<CandidateApiConfiguration>> mockCandidateApiClient, | ||
GetCandidateByActivityQueryHandler handler) | ||
{ | ||
var expectedGetCandidatesByActivityApiRequest = | ||
new GetCandidatesByActivityApiRequest(query.CutOffDateTime.ToString("O"), query.PageNumber, query.PageSize); | ||
|
||
mockCandidateApiClient | ||
.Setup(client => client.Get<GetCandidatesByActivityApiResponse>( | ||
It.Is<GetCandidatesByActivityApiRequest>(c => | ||
c.GetUrl == expectedGetCandidatesByActivityApiRequest.GetUrl))) | ||
.ReturnsAsync(mockCandidatesByActivityApiResponse); | ||
|
||
|
||
var actual = await handler.Handle(query, CancellationToken.None); | ||
|
||
actual.Should().NotBeNull(); | ||
actual.Candidates.Should().BeEquivalentTo(mockCandidatesByActivityApiResponse.Candidates); | ||
actual.PageSize.Should().Be(mockCandidatesByActivityApiResponse.PageSize); | ||
actual.PageIndex.Should().Be(mockCandidatesByActivityApiResponse.PageIndex); | ||
actual.TotalPages.Should().Be(mockCandidatesByActivityApiResponse.TotalPages); | ||
actual.TotalCount.Should().Be(mockCandidatesByActivityApiResponse.TotalCount); | ||
} | ||
} | ||
} |
123 changes: 123 additions & 0 deletions
123
...S.FindApprenticeshipJobs.UnitTests/Candidates/WhenHandlingUpdateCandidateStatusCommand.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,123 @@ | ||
using AutoFixture.NUnit3; | ||
using Moq; | ||
using NUnit.Framework; | ||
using SFA.DAS.FindApprenticeshipJobs.Application.Commands.Candidates; | ||
using SFA.DAS.FindApprenticeshipJobs.InnerApi.Requests; | ||
using SFA.DAS.FindApprenticeshipJobs.InnerApi.Responses; | ||
using SFA.DAS.SharedOuterApi.Configuration; | ||
using SFA.DAS.SharedOuterApi.Interfaces; | ||
using SFA.DAS.SharedOuterApi.Models; | ||
using SFA.DAS.Testing.AutoFixture; | ||
using System.Net; | ||
|
||
namespace SFA.DAS.FindApprenticeshipJobs.UnitTests.Candidates | ||
{ | ||
public class WhenHandlingUpdateCandidateStatusCommand | ||
{ | ||
[Test, MoqAutoData] | ||
public async Task Then_The_Put_Is_Sent_And_Data_Returned( | ||
string govUkId, | ||
UpdateCandidateStatusCommand command, | ||
GetCandidateApiResponse getCandidateApiResponse, | ||
PutCandidateApiResponse putCandidateApiResponse, | ||
[Frozen] Mock<ICandidateApiClient<CandidateApiConfiguration>> mockApiClient, | ||
UpdateCandidateStatusCommandHandler handler) | ||
{ | ||
command.GovUkIdentifier = govUkId; | ||
command.Email = getCandidateApiResponse.Email; | ||
var expectedGetCandidateRequest = new GetCandidateApiRequest(govUkId); | ||
mockApiClient.Setup(x => x.GetWithResponseCode<GetCandidateApiResponse>( | ||
It.Is<GetCandidateApiRequest>(r => r.GetUrl == expectedGetCandidateRequest.GetUrl))) | ||
.ReturnsAsync(new ApiResponse<GetCandidateApiResponse>(getCandidateApiResponse, HttpStatusCode.OK, string.Empty)); | ||
|
||
|
||
var expectedPutData = new PutCandidateApiRequestData | ||
{ | ||
Email = command.Email, | ||
Status = command.Status | ||
}; | ||
|
||
var expectedRequest = new PutCandidateApiRequest(getCandidateApiResponse.Id, expectedPutData); | ||
|
||
mockApiClient | ||
.Setup(client => client.PutWithResponseCode<PutCandidateApiResponse>( | ||
It.Is<PutCandidateApiRequest>(c => | ||
c.PutUrl == expectedRequest.PutUrl | ||
&& ((PutCandidateApiRequestData)c.Data).Email == command.Email))) | ||
.ReturnsAsync(new ApiResponse<PutCandidateApiResponse>(putCandidateApiResponse, HttpStatusCode.OK, string.Empty)); | ||
|
||
|
||
await handler.Handle(command, CancellationToken.None); | ||
|
||
mockApiClient.Verify(client => client.PutWithResponseCode<PutCandidateApiResponse>( | ||
It.Is<PutCandidateApiRequest>(c => | ||
c.PutUrl == expectedRequest.PutUrl | ||
&& ((PutCandidateApiRequestData)c.Data).Email == command.Email)), Times.Once()); | ||
} | ||
|
||
[Test, MoqAutoData] | ||
public async Task And_Api_Returns_Null_Then_Put_Never_Called( | ||
string govUkId, | ||
UpdateCandidateStatusCommand command, | ||
GetCandidateApiResponse getCandidateApiResponse, | ||
PutCandidateApiResponse putCandidateApiResponse, | ||
[Frozen] Mock<ICandidateApiClient<CandidateApiConfiguration>> mockApiClient, | ||
UpdateCandidateStatusCommandHandler handler) | ||
{ | ||
command.GovUkIdentifier = govUkId; | ||
command.Email = getCandidateApiResponse.Email; | ||
var expectedGetCandidateRequest = new GetCandidateApiRequest(govUkId); | ||
mockApiClient.Setup(x => x.GetWithResponseCode<GetCandidateApiResponse>( | ||
It.Is<GetCandidateApiRequest>(r => r.GetUrl == expectedGetCandidateRequest.GetUrl))) | ||
.ReturnsAsync(new ApiResponse<GetCandidateApiResponse>(null!, HttpStatusCode.NotFound, string.Empty)); | ||
|
||
|
||
var expectedPutData = new PutCandidateApiRequestData | ||
{ | ||
Email = command.Email, | ||
Status = command.Status | ||
}; | ||
|
||
var expectedRequest = new PutCandidateApiRequest(getCandidateApiResponse.Id, expectedPutData); | ||
|
||
await handler.Handle(command, CancellationToken.None); | ||
|
||
mockApiClient.Verify(client => client.PutWithResponseCode<PutCandidateApiResponse>( | ||
It.Is<PutCandidateApiRequest>(c => | ||
c.PutUrl == expectedRequest.PutUrl | ||
&& ((PutCandidateApiRequestData)c.Data).Email == command.Email)), Times.Never()); | ||
} | ||
|
||
[Test, MoqAutoData] | ||
public async Task And_Api_Returns_Different_Email_Then_Put_Never_Called( | ||
string govUkId, | ||
UpdateCandidateStatusCommand command, | ||
GetCandidateApiResponse getCandidateApiResponse, | ||
PutCandidateApiResponse putCandidateApiResponse, | ||
[Frozen] Mock<ICandidateApiClient<CandidateApiConfiguration>> mockApiClient, | ||
UpdateCandidateStatusCommandHandler handler) | ||
{ | ||
command.GovUkIdentifier = govUkId; | ||
var expectedGetCandidateRequest = new GetCandidateApiRequest(govUkId); | ||
mockApiClient.Setup(x => x.GetWithResponseCode<GetCandidateApiResponse>( | ||
It.Is<GetCandidateApiRequest>(r => r.GetUrl == expectedGetCandidateRequest.GetUrl))) | ||
.ReturnsAsync(new ApiResponse<GetCandidateApiResponse>(null!, HttpStatusCode.NotFound, string.Empty)); | ||
|
||
|
||
var expectedPutData = new PutCandidateApiRequestData | ||
{ | ||
Email = command.Email, | ||
Status = command.Status | ||
}; | ||
|
||
var expectedRequest = new PutCandidateApiRequest(getCandidateApiResponse.Id, expectedPutData); | ||
|
||
await handler.Handle(command, CancellationToken.None); | ||
|
||
mockApiClient.Verify(client => client.PutWithResponseCode<PutCandidateApiResponse>( | ||
It.Is<PutCandidateApiRequest>(c => | ||
c.PutUrl == expectedRequest.PutUrl | ||
&& ((PutCandidateApiRequestData)c.Data).Email == command.Email)), Times.Never()); | ||
} | ||
} | ||
} |
19 changes: 19 additions & 0 deletions
19
...indApprenticeshipJobs.UnitTests/InnerApi/WhenBuildingGetCandidatesByActivityApiRequest.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
using AutoFixture.NUnit3; | ||
using FluentAssertions; | ||
using NUnit.Framework; | ||
using SFA.DAS.FindApprenticeshipJobs.InnerApi.Requests; | ||
|
||
namespace SFA.DAS.FindApprenticeshipJobs.UnitTests.InnerApi | ||
{ | ||
[TestFixture] | ||
public class WhenBuildingGetCandidatesByActivityApiRequest | ||
{ | ||
[Test, AutoData] | ||
public void Then_The_Url_Is_Correctly_Built(string cutOffDateTime, int pageNumber, int pageSize) | ||
{ | ||
var actual = new GetCandidatesByActivityApiRequest(cutOffDateTime, pageNumber, pageSize); | ||
|
||
actual.GetUrl.Should().Be($"api/candidates/GetCandidatesByActivity?cutOffDateTime={cutOffDateTime}&pageNumber={pageNumber}&pageSize={pageSize}"); | ||
} | ||
} | ||
} |
16 changes: 16 additions & 0 deletions
16
...Jobs/SFA.DAS.FindApprenticeshipJobs.UnitTests/InnerApi/WhenBuildingPutCandidateRequest.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
using AutoFixture.NUnit3; | ||
using FluentAssertions; | ||
using NUnit.Framework; | ||
using SFA.DAS.FindApprenticeshipJobs.InnerApi.Requests; | ||
|
||
namespace SFA.DAS.FindApprenticeshipJobs.UnitTests.InnerApi; | ||
public class WhenBuildingPutCandidateRequest | ||
{ | ||
[Test, AutoData] | ||
public void Then_The_Request_Url_Is_Correctly_Built(Guid candidateId, PutCandidateApiRequestData data) | ||
{ | ||
var actual = new PutCandidateApiRequest(candidateId, data); | ||
|
||
actual.PutUrl.Should().Be($"/api/candidates/{candidateId}"); | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No cancellation token on this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved it as in comments