CSP-1760: FAT - 9. FAT Outer API endpoint GET /Courses #1915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- New endpoint to manage getting courses from courses api as well as gather provider count details from roatpv2 inner api. - Refactor GetTrainingCourseQueryHandler & GetTrainingCourseProviderQueryHandler to utilize new roatp inner api endpoint '/providers/count'. - Updated GetTrainingCourseQueryHandler, GetTrainingCourseProviderQueryHandler unit tests to reflect changes. - Unit test coverage for new GetCoursesQueryHandler.
* added AgreementNotSigned * 1. In case of closed vacancy, the response object could not be cast into GetApprenticeshipVacancyItemResponse This results in a vacancy item response as null. If the Email tokens are empty, then the email is not sent. 2. Vacancy service => Separation of Concerns rule violation split this implementation as separate methods GetVacancy from FAA Api & Closed Vacancy from RAA Api * Included NHS Vacancies count in the search Results * Update SFA.DAS.FindAnApprenticeship.csproj * Updated SFA.DAS.VacancyServices.Wage to version 1.0.35 * Saved Search Email alert Across England wording change * added failed requests alert and updated app connection string * CSP-1762: Get Course Levels endpoint and associated handler. * CSP-1762: Update unit test to use Assert.That * CSP-1762: Pushed unit test update to use fluent assertions to validate cover checker. --------- Co-authored-by: Paul Graham <[email protected]> Co-authored-by: Balaji Jambulingam <[email protected]> Co-authored-by: Liam Crossley <[email protected]> Co-authored-by: Siji Odunlami <[email protected]> Co-authored-by: Calum Rees <[email protected]> Co-authored-by: harsh-dfe <[email protected]> Co-authored-by: Calum Rees <[email protected]> Co-authored-by: Najam Muhammad <[email protected]>
* added AgreementNotSigned * 1. In case of closed vacancy, the response object could not be cast into GetApprenticeshipVacancyItemResponse This results in a vacancy item response as null. If the Email tokens are empty, then the email is not sent. 2. Vacancy service => Separation of Concerns rule violation split this implementation as separate methods GetVacancy from FAA Api & Closed Vacancy from RAA Api * Included NHS Vacancies count in the search Results * Update SFA.DAS.FindAnApprenticeship.csproj * Updated SFA.DAS.VacancyServices.Wage to version 1.0.35 * Saved Search Email alert Across England wording change * added failed requests alert and updated app connection string * WIP * CSP-1763: Levels controller method to return levels from courses api. --------- Co-authored-by: Paul Graham <[email protected]> Co-authored-by: Balaji Jambulingam <[email protected]> Co-authored-by: Liam Crossley <[email protected]> Co-authored-by: Siji Odunlami <[email protected]> Co-authored-by: Calum Rees <[email protected]> Co-authored-by: harsh-dfe <[email protected]> Co-authored-by: Calum Rees <[email protected]> Co-authored-by: Najam Muhammad <[email protected]>
…overlet.msbuild. Updated unit tests to reflect total providers count and providers count correctly.
* added AgreementNotSigned * 1. In case of closed vacancy, the response object could not be cast into GetApprenticeshipVacancyItemResponse This results in a vacancy item response as null. If the Email tokens are empty, then the email is not sent. 2. Vacancy service => Separation of Concerns rule violation split this implementation as separate methods GetVacancy from FAA Api & Closed Vacancy from RAA Api * Included NHS Vacancies count in the search Results * Update SFA.DAS.FindAnApprenticeship.csproj * Updated SFA.DAS.VacancyServices.Wage to version 1.0.35 * Saved Search Email alert Across England wording change * added failed requests alert and updated app connection string * CSP-1762: Get Course Levels endpoint and associated handler. * CSP-1762: Update unit test to use Assert.That * CSP-1762: Pushed unit test update to use fluent assertions to validate cover checker. --------- Co-authored-by: Paul Graham <[email protected]> Co-authored-by: Balaji Jambulingam <[email protected]> Co-authored-by: Liam Crossley <[email protected]> Co-authored-by: Siji Odunlami <[email protected]> Co-authored-by: Calum Rees <[email protected]> Co-authored-by: harsh-dfe <[email protected]> Co-authored-by: Calum Rees <[email protected]> Co-authored-by: Najam Muhammad <[email protected]>
* added AgreementNotSigned * 1. In case of closed vacancy, the response object could not be cast into GetApprenticeshipVacancyItemResponse This results in a vacancy item response as null. If the Email tokens are empty, then the email is not sent. 2. Vacancy service => Separation of Concerns rule violation split this implementation as separate methods GetVacancy from FAA Api & Closed Vacancy from RAA Api * Included NHS Vacancies count in the search Results * Update SFA.DAS.FindAnApprenticeship.csproj * Updated SFA.DAS.VacancyServices.Wage to version 1.0.35 * Saved Search Email alert Across England wording change * added failed requests alert and updated app connection string * WIP * CSP-1763: Levels controller method to return levels from courses api. --------- Co-authored-by: Paul Graham <[email protected]> Co-authored-by: Balaji Jambulingam <[email protected]> Co-authored-by: Liam Crossley <[email protected]> Co-authored-by: Siji Odunlami <[email protected]> Co-authored-by: Calum Rees <[email protected]> Co-authored-by: harsh-dfe <[email protected]> Co-authored-by: Calum Rees <[email protected]> Co-authored-by: Najam Muhammad <[email protected]>
DevenKShah
force-pushed
the
FAT-25-Development
branch
from
3448f43 to
1254a89
Compare
…t tests to correct directory.
* added AgreementNotSigned * 1. In case of closed vacancy, the response object could not be cast into GetApprenticeshipVacancyItemResponse This results in a vacancy item response as null. If the Email tokens are empty, then the email is not sent. 2. Vacancy service => Separation of Concerns rule violation split this implementation as separate methods GetVacancy from FAA Api & Closed Vacancy from RAA Api * Included NHS Vacancies count in the search Results * Update SFA.DAS.FindAnApprenticeship.csproj * Updated SFA.DAS.VacancyServices.Wage to version 1.0.35 * Saved Search Email alert Across England wording change * added failed requests alert and updated app connection string * CSP-1762: Get Course Levels endpoint and associated handler. * CSP-1762: Update unit test to use Assert.That * CSP-1762: Pushed unit test update to use fluent assertions to validate cover checker. --------- Co-authored-by: Paul Graham <[email protected]> Co-authored-by: Balaji Jambulingam <[email protected]> Co-authored-by: Liam Crossley <[email protected]> Co-authored-by: Siji Odunlami <[email protected]> Co-authored-by: Calum Rees <[email protected]> Co-authored-by: harsh-dfe <[email protected]> Co-authored-by: Calum Rees <[email protected]> Co-authored-by: Najam Muhammad <[email protected]>
* added AgreementNotSigned * 1. In case of closed vacancy, the response object could not be cast into GetApprenticeshipVacancyItemResponse This results in a vacancy item response as null. If the Email tokens are empty, then the email is not sent. 2. Vacancy service => Separation of Concerns rule violation split this implementation as separate methods GetVacancy from FAA Api & Closed Vacancy from RAA Api * Included NHS Vacancies count in the search Results * Update SFA.DAS.FindAnApprenticeship.csproj * Updated SFA.DAS.VacancyServices.Wage to version 1.0.35 * Saved Search Email alert Across England wording change * added failed requests alert and updated app connection string * WIP * CSP-1763: Levels controller method to return levels from courses api. --------- Co-authored-by: Paul Graham <[email protected]> Co-authored-by: Balaji Jambulingam <[email protected]> Co-authored-by: Liam Crossley <[email protected]> Co-authored-by: Siji Odunlami <[email protected]> Co-authored-by: Calum Rees <[email protected]> Co-authored-by: harsh-dfe <[email protected]> Co-authored-by: Calum Rees <[email protected]> Co-authored-by: Najam Muhammad <[email protected]>
DevenKShah
force-pushed
the
FAT-25-Development
branch
from
1254a89 to
270f5ab
Compare
…corporated logic to get location item from location lookup service. Remove retired training courses endpoint.
…stResponse class object. Updated unit test coverage accordingly.
MarkFCain
force-pushed
the
FAT-25-Development
branch
from
bc73317 to
b924814
Compare
DevenKShah
approved these changes
Feb 24, 2025
Comment on lines
+41
to
+46
| new GetCourseTrainingProvidersCountRequest( | ||
| [request.Id], | ||
| null, | ||
| null, | ||
| null | ||
| ) |
There was a problem hiding this comment.
I am assuming that this will be refactored when we pick up course details page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New endpoint to manage getting courses from courses api as well as gather provider count details from roatpv2 inner api.
Refactor GetTrainingCourseQueryHandler & GetTrainingCourseProviderQueryHandler to utilize new RAOTP inner API endpoint '/providers/count'.
Updated GetTrainingCourseQueryHandler, GetTrainingCourseProviderQueryHandler unit tests to reflect changes.
Unit test coverage for new GetCoursesQueryHandler.