Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APR-1576 - Add Polly to ApiClient #522

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

martin-lush
Copy link
Contributor

No description provided.

Copy link
Contributor

@MichaelYoung1981 MichaelYoung1981 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the number of retries be put in config?

MarkFCain
MarkFCain previously approved these changes Apr 14, 2020
@David-B-Read
Copy link
Contributor

Can the number of retries be put in config?

Would make sense for the retry delay to go in there as well

@martin-lush
Copy link
Contributor Author

Further investigation needs to be done on this branch as it appears Polly is not throwing exceptions up the stack in some cases and returns null instead

@MarkFCain MarkFCain changed the base branch from APR-1570_apiclient_logging to master August 7, 2020 12:48
@MarkFCain MarkFCain dismissed their stale review August 7, 2020 12:48

The base branch was changed.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants