APR-2667 - Fixed section 6.2 so it retains answers for Main & Employers upon change route #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs upon change route
martin-lush
requested review from
chrisfoster76,
DannyGB and
MarkFCain
as code owners
sureshkuruva1
previously approved these changes
Sep 23, 2021
MarkFCain
reviewed
Sep 23, 2021
src/SFA.DAS.ApplyService.Application/Apply/Roatp/RoatpPreambleQuestionBuilder.cs
Show resolved
Hide resolved
MarkFCain
reviewed
Sep 23, 2021
src/SFA.DAS.ApplyService.Application/Apply/Roatp/RoatpPreambleQuestionBuilder.cs
Show resolved
Hide resolved
MarkFCain
reviewed
Sep 23, 2021
| case RoatpWorkflowPageIds.PlanningApprenticeshipTraining.TypeOfApprenticeshipTraining_Employer: | ||
| return "Type of apprenticeship training"; | ||
| case RoatpWorkflowPageIds.PlanningApprenticeshipTraining.TypeOfApprenticeshipTraining_MainEmployer: | ||
| case RoatpWorkflowPageIds.PlanningApprenticeshipTraining.TypeOfApprenticeshipTraining_Employer_OLD_PAGE_ID: |
There was a problem hiding this comment.
Existing applications have the old ids
MarkFCain
reviewed
Sep 23, 2021
| case RoatpWorkflowPageIds.PlanningApprenticeshipTraining.ApprenticeshipStandards_NewEmployer: | ||
| return "Delivering training in apprenticeship standards"; | ||
| case RoatpWorkflowPageIds.PlanningApprenticeshipTraining.ApprenticeshipStandards_NewMainEmployer: | ||
| case RoatpWorkflowPageIds.PlanningApprenticeshipTraining.ApprenticeshipStandards_NewEmployer_OLD_PAGE_ID: |
There was a problem hiding this comment.
see first comment.
However, I'm guessing we want to keep them here for past/ongoing cases?
There was a problem hiding this comment.
Existing applications have the old ids
MarkFCain
previously approved these changes
Sep 23, 2021
martin-lush
dismissed stale reviews from MarkFCain and sureshkuruva1
via
2c415a1
|
Kudos, SonarCloud Quality Gate passed! |
MarkFCain
approved these changes
Nov 4, 2021
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.