Refactored SFA.DAS.Payments.ScheduledJobs Az Function #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y for apprenticeship data processing and validation, and the configuration of new database contexts and services. These changes enhance the codebase by improving readability, adding new features, and ensuring proper configuration and dependency injection for the new functionalities.
Updated using directives in AuditDataCleanUpService.cs to include Newtonsoft.Json. Refactored SplitBatchAndEnqueueMessages method to serialize messages using JsonConvert.SerializeObject before sending to the queue. This ensures consistent message format and improves code maintainability.
Introduced a try-catch block around the deserialization of `message.Body` and the call to `_auditDataCleanUpService. DataLockEventAuditDataCleanUp(batch)`. This change ensures that any exceptions during these operations are caught and logged with an error message, including the exception details and the `MessageId` of the message being processed. This improves the robustness of the `Run` method by preventing silent failures or crashes, aiding in better issue diagnosis and application stability.
added 4 commits
January 9, 2025 11:11
Renamed namespace `SFA.DAS.Payments.ScheduledJobs.DTOS` to `SFA.DAS.Payments.ScheduledJobs.Dtos` across multiple files. Removed unused using directives from various files,
The `ServiceBusConnectionString` property has been removed from the `AppsettingsOptions` class. Correspondingly, the retrieval of the `ServiceBusConnectionString` configuration value has been removed from the `DependencyInjection` class within the `SFA.DAS.Payments.ScheduledJobs.Ioc` namespace. This indicates that the application no longer requires the `ServiceBusConnectionString` configuration setting.
Corrected class name from AppsettingsOptions to AppSettingsOptions in SFA.DAS.Payments.ScheduledJobs.Configuration and SFA.DAS.Payments.ScheduledJobs.Ioc namespaces. Added ServiceBusConnectionString property to AppSettingsOptions class for storing the Service Bus connection string.
| @@ -0,0 +1,54 @@ | |||
| namespace SFA.DAS.Payments.ScheduledJobs.Configuration | |||
| { | |||
| public class AppSettingsOptions : IAppSettingsOptions | |||
There was a problem hiding this comment.
Can the capitalization on the filename for this and the IAppsettingsOptions file be modified to match the class/interface names please?
There was a problem hiding this comment.
I have renamed the file name.
| public string CurrentCollectionPeriod { get; set; } | ||
| public string CurrentAcademicYear { get; set; } | ||
| public string PreviousAcademicYearCollectionPeriod { get; set; } | ||
| public string PerviousAcademicYear { get; set; } |
There was a problem hiding this comment.
Renamed the variable
| public string PreviousAcademicYear { get; set; } | ||
| } | ||
|
|
||
| public class Connectionstrings |
There was a problem hiding this comment.
Can this be capitalized to ConnectionStrings please?
There was a problem hiding this comment.
I have change the variable names
| LevyAccountSchedule = configHelper.GetValue<string>("LevyAccountSchedule"), | ||
| LevyAccountValidationSchedule = configHelper.GetValue<string>("LevyAccountValidationSchedule"), | ||
| LogLevel = configHelper.GetValue<string>("LogLevel"), | ||
| PerviousAcademicYear = configHelper.GetValue<string>("PerviousAcademicYear"), |
There was a problem hiding this comment.
Typo in property / config variable
There was a problem hiding this comment.
I have fixed the name
| { | ||
| services.AddScoped<IAuditDataCleanUpService, AuditDataCleanUpService>(); | ||
| services.AddScoped<IPaymentLogger, PaymentLogger>(); | ||
| //services.AddScoped<IEndpointInstanceFactory, EndpointInstanceFactory>(); |
Corrected typos in `AppSettingsOptions` and `IAppSettingsOptions`: - Renamed `Connectionstrings` to `ConnectionStrings` - Renamed `PerviousAcademicYear` to `PreviousAcademicYear` Updated `DependencyInjection.cs`: - Fixed instantiation to use `ConnectionStrings` - Corrected configuration key `PerviousAcademicYear` - Removed unused commented-out line
David-B-Read
approved these changes
Jan 16, 2025
LiamWright
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4
This Pull Request includes updates related to the .NET 6 upgrade and the removal of legacy components such as Autofac and NServiceBus configuration. It also incorporates the use of output bindings for Azure Service Bus queues. The primary goal is to streamline future upgrade processes and leverage the Microsoft ecosystem libraries.
By isolating Azure Functions, services, models, DbContexts, DTOs, configurations, enums, validators, and dependency injections into separate folders, the project structure is now more organized and easier to understand. This reorganization aims to facilitate smoother transitions to future .NET versions (e.g., .NET 8, .NET 9) with minimal changes required in the repository. Given Microsoft's evolving practices and patterns, this approach minimizes the challenges associated with third-party libraries.