Cv 588 Select New employer

src/SFA.DAS.ProviderCommitments/SFA.DAS.ProviderCommitments.Web.UnitTests/Controllers/ApprenticesControllerTests/WhenGettingSelectEmployer.cs

@@ -0,0 +1,76 @@
+using Microsoft.AspNetCore.Mvc;
+using Moq;
+using NUnit.Framework;
+using SFA.DAS.CommitmentsV2.Shared.Interfaces;
+using SFA.DAS.ProviderCommitments.Web.Controllers;
+using SFA.DAS.ProviderCommitments.Web.Models.Apprentice;
+using SFA.DAS.ProviderCommitments.Web.Models.Shared;
+using SFA.DAS.ProviderCommitments.Web.Requests.Apprentice;
+using System.Collections.Generic;
+using System.Threading.Tasks;
+
+namespace SFA.DAS.ProviderCommitments.Web.UnitTests.Controllers.ApprenticesControllerTests
+{
+    [TestFixture]
+    public class WhenGettingSelectEmployer
+    {
+        [Test]
+        public async Task ThenCallsModelMapper()
+        {
+            var fixture = new SelectEmployerFixture();
+
+            await fixture.Act();
+
+            fixture.VerifyMapperWasCalled();
+        }
+
+        [Test]
+        public async Task ThenReturnsView()
+        {
+            var fixture = new SelectEmployerFixture();
+
+            var result = await fixture.Act() as ViewResult;
+
+            Assert.NotNull(result);
+            Assert.AreEqual(typeof(SelectEmployerViewModel), result.Model.GetType());
+        }
+    }
+
+    public class SelectEmployerFixture
+    {
+        public ApprenticeController Sut { get; set; }
+
+        private readonly Mock<IModelMapper> _modelMapperMock;
+        private readonly SelectEmployerViewModel _viewModel;
+        private readonly SelectEmployerRequest _request;
+
+        public SelectEmployerFixture()
+        {
+            _request = new SelectEmployerRequest { ProviderId = 1, ApprenticeshipId = 1 };
+            _modelMapperMock = new Mock<IModelMapper>();
+            _viewModel = new SelectEmployerViewModel
+            {
+                AccountProviderLegalEntities = new List<AccountProviderLegalEntityViewModel>(),
+            };
+
+            _modelMapperMock
+                .Setup(x => x.Map<SelectEmployerViewModel>(_request))
+                .ReturnsAsync(_viewModel);
+
+            Sut = new ApprenticeController(_modelMapperMock.Object);
+        }
+
+        public SelectEmployerFixture WithModelStateErrors()
+        {
+            Sut.ControllerContext.ModelState.AddModelError("TestError", "Test Error");
+            return this;
+        }
+
+        public void VerifyMapperWasCalled()
+        {
+            _modelMapperMock.Verify(x => x.Map<SelectEmployerViewModel>(_request));
+        }
+
+        public async Task<IActionResult> Act() => await Sut.SelectEmployer(_request);
+    }
+}

src/SFA.DAS.ProviderCommitments/SFA.DAS.ProviderCommitments.Web.UnitTests/Controllers/CohortControllerTests/WhenGettingConfirmEmployer.cs

@@ -3,13 +3,13 @@
 using NUnit.Framework;
 using SFA.DAS.CommitmentsV2.Shared.Interfaces;
 using SFA.DAS.ProviderCommitments.Web.Controllers;
-using SFA.DAS.ProviderCommitments.Web.Models;
-using SFA.DAS.ProviderCommitments.Web.Requests;
 using SFA.DAS.ProviderUrlHelper;
 using AutoFixture;
 using System.Threading.Tasks;
 using Microsoft.AspNetCore.Mvc;
 using SFA.DAS.CommitmentsV2.Api.Client;
+using SFA.DAS.ProviderCommitments.Web.Requests.Cohort;
+using SFA.DAS.ProviderCommitments.Web.Models.Cohort;
 
 namespace SFA.DAS.ProviderCommitments.Web.UnitTests.Controllers.CohortControllerTests
 {

src/SFA.DAS.ProviderCommitments/SFA.DAS.ProviderCommitments.Web.UnitTests/Controllers/CohortControllerTests/WhenGettingSelectEmployer.cs

@@ -7,8 +7,9 @@
 using SFA.DAS.CommitmentsV2.Api.Client;
 using SFA.DAS.CommitmentsV2.Shared.Interfaces;
 using SFA.DAS.ProviderCommitments.Web.Controllers;
-using SFA.DAS.ProviderCommitments.Web.Models;
-using SFA.DAS.ProviderCommitments.Web.Requests;
+using SFA.DAS.ProviderCommitments.Web.Models.Cohort;
+using SFA.DAS.ProviderCommitments.Web.Models.Shared;
+using SFA.DAS.ProviderCommitments.Web.Requests.Cohort;
 using SFA.DAS.ProviderUrlHelper;
 
 namespace SFA.DAS.ProviderCommitments.Web.UnitTests.Controllers.CohortControllerTests

src/SFA.DAS.ProviderCommitments/SFA.DAS.ProviderCommitments.Web.UnitTests/Controllers/CohortControllerTests/WhenIPostConfirmEmployer.cs

@@ -10,6 +10,7 @@
 using System.Threading.Tasks;
 using System.Threading;
 using SFA.DAS.CommitmentsV2.Api.Client;
+using SFA.DAS.ProviderCommitments.Web.Models.Cohort;
 
 namespace SFA.DAS.ProviderCommitments.Web.UnitTests.Controllers.CohortControllerTests
 {

src/SFA.DAS.ProviderCommitments/SFA.DAS.ProviderCommitments.Web.UnitTests/Mappers/ConfirmEmployerRequestToViewModelMapperTests/WhenIMapConfrimEmployerRequestToConfirmEmployerViewModel.cs

@@ -2,9 +2,9 @@
 using Moq;
 using NUnit.Framework;
 using SFA.DAS.CommitmentsV2.Api.Client;
-using SFA.DAS.ProviderCommitments.Web.Mappers;
-using SFA.DAS.ProviderCommitments.Web.Models;
-using SFA.DAS.ProviderCommitments.Web.Requests;
+using SFA.DAS.ProviderCommitments.Web.Mappers.Cohort;
+using SFA.DAS.ProviderCommitments.Web.Models.Cohort;
+using SFA.DAS.ProviderCommitments.Web.Requests.Cohort;
 using System;
 using System.Threading;
 using System.Threading.Tasks;

src/SFA.DAS.ProviderCommitments/SFA.DAS.ProviderCommitments.Web.UnitTests/Mappers/ConfirmEmployerViewModelToCreateEmptyCohortRequestMapperTests/WhenIMapConfrimEmployerViewModelToCreateEmptyCohortRequest.cs

@@ -4,8 +4,8 @@
 using SFA.DAS.CommitmentsV2.Api.Client;
 using SFA.DAS.CommitmentsV2.Api.Types.Requests;
 using SFA.DAS.CommitmentsV2.Api.Types.Responses;
-using SFA.DAS.ProviderCommitments.Web.Mappers;
-using SFA.DAS.ProviderCommitments.Web.Models;
+using SFA.DAS.ProviderCommitments.Web.Mappers.Cohort;
+using SFA.DAS.ProviderCommitments.Web.Models.Cohort;
 using System;
 using System.Threading;
 using System.Threading.Tasks;

src/SFA.DAS.ProviderCommitments/SFA.DAS.ProviderCommitments.Web.UnitTests/Mappers/SelectApprenticeEmployerRequestToViewModelTests/WhenIMapSelectEmployerRequestToViewModel.cs

@@ -0,0 +1,181 @@
+using System.Collections.Generic;
+using System.Linq;
+using System.Threading;
+using System.Threading.Tasks;
+using Moq;
+using NUnit.Framework;
+using SFA.DAS.CommitmentsV2.Api.Client;
+using SFA.DAS.ProviderCommitments.Web.Mappers.Apprentice;
+using SFA.DAS.ProviderCommitments.Web.Models.Apprentice;
+using SFA.DAS.ProviderCommitments.Web.Requests.Apprentice;
+using SFA.DAS.ProviderRelationships.Api.Client;
+using SFA.DAS.ProviderRelationships.Types.Dtos;
+using SFA.DAS.ProviderRelationships.Types.Models;
+
+namespace SFA.DAS.ProviderCommitments.Web.UnitTests.Mappers.SelectApprenticeEmployerRequestToViewModelTests
+{
+    [TestFixture]
+    public class WhenIMapSelectEmployerRequestToViewModel
+    {
+        [Test]
+        public async Task ThenCallsProviderRelationshipsApiClient()
+        {
+            var fixture = new SelectEmployerViewModelMapperFixture();
+
+            await fixture.Act();
+
+            fixture.Verify_ProviderRelationshipsApiClientWasCalled_Once();
+        }
+
+        [Test]
+        public async Task ThenCallsCommitmentsApiClient()
+        {
+            var fixture = new SelectEmployerViewModelMapperFixture();
+
+            await fixture.Act();
+
+            fixture.Verify_CommitmentApiClientWasCalled_Once();
+        }
+
+        [Test]
+        public async Task ThenCorrectlyMapsApiResponseToViewModel()
+        {
+            var fixture = new SelectEmployerViewModelMapperFixture();
+
+            var result = await fixture.Act();
+
+            fixture.Assert_SelectEmployerViewModelCorrectlyMapped(result);
+        }
+
+        [Test]
+        public async Task ThenDontReturnTheExistingEmployer()
+        {
+            var fixture = new SelectEmployerViewModelMapperFixture();
+
+            var result = await fixture.Act();
+
+            fixture.Assert_SelectEmployerViewModelCorrectlyMapped(result);
+        }
+
+        [Test]
+        public async Task ThenCorrectlyMapsEmptyApiResponseToViewModel()
+        {
+            var fixture = new SelectEmployerViewModelMapperFixture().WithNoMatchingEmployers();
+
+            var result = await fixture.Act();
+
+            fixture.Assert_ListOfEmployersIsEmpty(result);
+        }
+    }
+
+    public class SelectEmployerViewModelMapperFixture
+    {
+        private readonly SelectEmployerViewModelMapper _sut;
+        private readonly Mock<IProviderRelationshipsApiClient> _providerRelationshipsApiClientMock;
+        private readonly Mock<ICommitmentsApiClient> _commitmentApiClientMock;
+        private readonly SelectEmployerRequest _request;
+        private readonly long _providerId;
+        private readonly long _accountLegalEntityId;
+        private readonly long _apprenticeshipId;
+        private readonly GetAccountProviderLegalEntitiesWithPermissionResponse _apiResponse;
+
+        public SelectEmployerViewModelMapperFixture()
+        {
+            _providerId = 123;
+            _accountLegalEntityId = 457;
+            _apprenticeshipId = 1;
+        _request = new SelectEmployerRequest { ProviderId = _providerId, ApprenticeshipId = _apprenticeshipId};
+            _apiResponse = new GetAccountProviderLegalEntitiesWithPermissionResponse
+            {
+                AccountProviderLegalEntities = new List<AccountProviderLegalEntityDto>
+                {
+                    new AccountProviderLegalEntityDto
+                    {
+                        AccountId = 123,
+                        AccountLegalEntityPublicHashedId = "DSFF23",
+                        AccountLegalEntityName = "TestAccountLegalEntityName",
+                        AccountPublicHashedId = "DFKFK66",
+                        AccountName = "TestAccountName",
+                        AccountLegalEntityId = 456,
+                        AccountProviderId = 234
+                    },
+                     new AccountProviderLegalEntityDto
+                    {
+                        AccountId = 124,
+                        AccountLegalEntityPublicHashedId = "DSFF24",
+                        AccountLegalEntityName = "TestAccountLegalEntityName2",
+                        AccountPublicHashedId = "DFKFK67",
+                        AccountName = "TestAccountNam2",
+                        AccountLegalEntityId = _accountLegalEntityId,
+                        AccountProviderId = 235
+                    }
+                }
+            };
+
+            _providerRelationshipsApiClientMock = new Mock<IProviderRelationshipsApiClient>();
+            _providerRelationshipsApiClientMock
+                .Setup(x => x.GetAccountProviderLegalEntitiesWithPermission(
+                    It.IsAny<GetAccountProviderLegalEntitiesWithPermissionRequest>(),
+                    CancellationToken.None))
+                .ReturnsAsync(_apiResponse);
+
+            _commitmentApiClientMock = new Mock<ICommitmentsApiClient>();
+
+            _commitmentApiClientMock.Setup(x => x.GetApprenticeship(_apprenticeshipId, It.IsAny<CancellationToken>()))
+                .ReturnsAsync(new CommitmentsV2.Api.Types.Responses.GetApprenticeshipResponse
+                {
+                    AccountLegalEntityId = _accountLegalEntityId
+                });
+
+            _sut = new SelectEmployerViewModelMapper(_providerRelationshipsApiClientMock.Object, _commitmentApiClientMock.Object);
+        }
+
+        public async Task<SelectEmployerViewModel> Act() => await _sut.Map(_request);
+
+
+        public SelectEmployerViewModelMapperFixture WithNoMatchingEmployers()
+        {
+            _providerRelationshipsApiClientMock
+                .Setup(x => x.GetAccountProviderLegalEntitiesWithPermission(
+                    It.IsAny<GetAccountProviderLegalEntitiesWithPermissionRequest>(),
+                    CancellationToken.None))
+                .ReturnsAsync(new GetAccountProviderLegalEntitiesWithPermissionResponse());
+
+            return this;
+        }
+
+        public void Verify_ProviderRelationshipsApiClientWasCalled_Once()
+        {
+            _providerRelationshipsApiClientMock.Verify(x => x.GetAccountProviderLegalEntitiesWithPermission(
+                It.Is<GetAccountProviderLegalEntitiesWithPermissionRequest>(y => 
+                    y.Ukprn == _request.ProviderId &&
+                    y.Operation == Operation.CreateCohort), CancellationToken.None), Times.Once);
+        }
+
+        public void Verify_CommitmentApiClientWasCalled_Once()
+        {
+            _commitmentApiClientMock.Verify(x => x.GetApprenticeship(_apprenticeshipId, CancellationToken.None), Times.Once);
+        }
+
+        public void Assert_SelectEmployerViewModelCorrectlyMapped(Web.Models.Apprentice.SelectEmployerViewModel result)
+        {
+            var filteredLegalEntities = _apiResponse.AccountProviderLegalEntities.Where(x => x.AccountLegalEntityId != _accountLegalEntityId);
+            Assert.AreEqual(filteredLegalEntities.Count(), result.AccountProviderLegalEntities.Count());
+
+            foreach (var entity in filteredLegalEntities)
+            {
+                Assert.True(result.AccountProviderLegalEntities.Any(x => 
+                    x.EmployerAccountLegalEntityName == entity.AccountLegalEntityName &&
+                    x.EmployerAccountLegalEntityPublicHashedId == entity.AccountLegalEntityPublicHashedId &&
+                    x.EmployerAccountName == entity.AccountName &&
+                    x.EmployerAccountPublicHashedId == entity.AccountPublicHashedId));
+            }
+        }
+
+        public void Assert_ListOfEmployersIsEmpty(SelectEmployerViewModel result)
+        {
+            Assert.AreEqual(0, result.AccountProviderLegalEntities.Count());
+        }
+    }
+}
+

src/SFA.DAS.ProviderCommitments/SFA.DAS.ProviderCommitments.Web.UnitTests/Mappers/SelectEmployerRequestToViewModelTests/WhenIMapSelectEmployerRequestToViewModel.cs → src/SFA.DAS.ProviderCommitments/SFA.DAS.ProviderCommitments.Web.UnitTests/Mappers/SelectCohortEmployerRequestToViewModelTests/WhenIMapSelectEmployerRequestToViewModel.cs

@@ -4,15 +4,14 @@
 using System.Threading.Tasks;
 using Moq;
 using NUnit.Framework;
-using SFA.DAS.ProviderCommitments.Web.Mappers;
-using SFA.DAS.ProviderCommitments.Web.Models;
-using SFA.DAS.ProviderCommitments.Web.Requests;
+using SFA.DAS.ProviderCommitments.Web.Mappers.Cohort;
+using SFA.DAS.ProviderCommitments.Web.Models.Cohort;
+using SFA.DAS.ProviderCommitments.Web.Requests.Cohort;
 using SFA.DAS.ProviderRelationships.Api.Client;
 using SFA.DAS.ProviderRelationships.Types.Dtos;
 using SFA.DAS.ProviderRelationships.Types.Models;
-using SFA.DAS.ProviderUrlHelper;
 
-namespace SFA.DAS.ProviderCommitments.Web.UnitTests.Mappers.SelectEmployerRequestToViewModelTests
+namespace SFA.DAS.ProviderCommitments.Web.UnitTests.Mappers.SelectCohortEmployerRequestToViewModelTests
 {
     [TestFixture]
     public class WhenIMapSelectEmployerRequestToViewModel

src/SFA.DAS.ProviderCommitments/SFA.DAS.ProviderCommitments.Web.UnitTests/Validators/Apprentice/SelectEmployerRequestValidatorTests.cs

@@ -0,0 +1,44 @@
+using NUnit.Framework;
+using SFA.DAS.ProviderCommitments.Web.Requests.Apprentice;
+using System;
+using System.Linq.Expressions;
+using FluentValidation.TestHelper;
+using SFA.DAS.ProviderCommitments.Web.Validators.Apprentice;
+
+namespace SFA.DAS.ProviderCommitments.Web.UnitTests.Validators.Apprentice
+{
+    [TestFixture]
+    public class SelectEmployerRequestValidatorTests
+    {
+
+        [TestCase(0, false)]
+        [TestCase(1, true)]
+        public void ThenProviderIdIsValidated(long providerId, bool expectedValid)
+        {
+            var request = new SelectEmployerRequest { ProviderId = providerId };
+            AssertValidationResult(x => x.ProviderId, request, expectedValid);
+        }
+
+        [TestCase(0, false)]
+        [TestCase(1, true)]
+        public void ThenApprenticeshipIdIsValidated(long apprenticeshipId, bool expectedValid)
+        {
+            var request = new SelectEmployerRequest { ApprenticeshipId = apprenticeshipId };
+            AssertValidationResult(x => x.ApprenticeshipId, request, expectedValid);
+        }
+
+        private void AssertValidationResult<T>(Expression<Func<SelectEmployerRequest, T>> property, SelectEmployerRequest instance, bool expectedValid)
+        {
+            var validator = new SelectEmployerRequestValidator();
+
+            if (expectedValid)
+            {
+                validator.ShouldNotHaveValidationErrorFor(property, instance);
+            }
+            else
+            {
+                validator.ShouldHaveValidationErrorFor(property, instance);
+            }
+        }
+    }
+}

src/SFA.DAS.ProviderCommitments/SFA.DAS.ProviderCommitments.Web.UnitTests/Validators/ConfirmEmployerRequestValidatorTests.cs → src/SFA.DAS.ProviderCommitments/SFA.DAS.ProviderCommitments.Web.UnitTests/Validators/Cohort/ConfirmEmployerRequestValidatorTests.cs

@@ -1,11 +1,11 @@
 using FluentValidation.TestHelper;
 using NUnit.Framework;
-using SFA.DAS.ProviderCommitments.Web.Requests;
-using SFA.DAS.ProviderCommitments.Web.Validators;
+using SFA.DAS.ProviderCommitments.Web.Requests.Cohort;
+using SFA.DAS.ProviderCommitments.Web.Validators.Cohort;
 using System;
 using System.Linq.Expressions;
 
-namespace SFA.DAS.ProviderCommitments.Web.UnitTests.Validators
+namespace SFA.DAS.ProviderCommitments.Web.UnitTests.Validators.Cohort
 {
     [TestFixture]
     public class ConfirmEmployerRequestValidatorTests