CON-954: Resolved PR comments

src/Communication/Communication.Types/ICommunicationRepository.cs

@@ -12,6 +12,6 @@ public interface ICommunicationRepository
         Task UpdateAsync(CommunicationMessage commMsg);
         Task<IEnumerable<CommunicationMessage>> GetScheduledMessagesSinceAsync(string requestType, DeliveryFrequency frequency, DateTime from, DateTime to);
         Task UpdateScheduledMessagesAsSentAsync(IEnumerable<Guid> msgIds, Guid aggregatedMessageId);
-        Task HardDelete(DateTime dispatchDateTime);
+        Task HardDelete(DateTime hardDeleteCommunicationMessagesStaleDateTime);
     }
 }

src/Data/CosmosDb/Console.RecruitSeedDataWriter/Data/RecruitWebJobsSystem.json

@@ -3,5 +3,6 @@
     "disabledJobs" : ["VacancyAnalyticsSummaryGeneratorJob"],
     "queryStoreDocumentsStaleByDays" : 90,
     "draftVacanciesStaleByDays" : 180,
-    "referredVacanciesStaleByDays" : 90
+    "referredVacanciesStaleByDays" : 90,
+	  "hardDeleteCommunicationMessagesStaleByDays" : 180
 }

src/Jobs/Recruit.Vacancies.Jobs.UnitTests/Triggers/QueueTriggers/CommunicationsHouseKeepingQueueTriggerTests.cs

@@ -14,8 +14,9 @@ namespace Recruit.Vacancies.Jobs.UnitTests.Triggers.QueueTriggers
 {
     public class CommunicationsHouseKeepingQueueTriggerTests
     {
+        private const int Days = 180;
         private readonly Mock<ILogger<CommunicationsHouseKeepingQueueTrigger>> _loggerMock = new Mock<ILogger<CommunicationsHouseKeepingQueueTrigger>>();
-        private readonly RecruitWebJobsSystemConfiguration _jobsConfig = new RecruitWebJobsSystemConfiguration() {  };
+        private readonly RecruitWebJobsSystemConfiguration _jobsConfig = new RecruitWebJobsSystemConfiguration() { HardDeleteCommunicationMessagesStaleByDays = Days };
         private readonly Mock<ITimeProvider> _timeProviderMock = new Mock<ITimeProvider>();
         private readonly Mock<ICommunicationRepository> _communicationRepositoryMock = new Mock<ICommunicationRepository>();
 

src/Jobs/Recruit.Vacancies.Jobs/Configuration/RecruitWebJobsSystemConfiguration.cs

@@ -9,5 +9,6 @@ public class RecruitWebJobsSystemConfiguration
         public int? QueryStoreDocumentsStaleByDays { get; set; }
         public int? DraftVacanciesStaleByDays { get; set; }
         public int? ReferredVacanciesStaleByDays { get; set; }
+        public int? HardDeleteCommunicationMessagesStaleByDays { get; set; }
     }
 }

src/Jobs/Recruit.Vacancies.Jobs/Triggers/QueueTriggers/CommunicationsHouseKeepingQueueTrigger.cs

@@ -18,7 +18,7 @@ public class CommunicationsHouseKeepingQueueTrigger
         private readonly RecruitWebJobsSystemConfiguration _jobsConfig;
         private readonly ITimeProvider _timeProvider;
         private readonly ICommunicationRepository _communicationRepository;
-
+        private const int DefaultStaleByDays = 180;
         private string JobName => GetType().Name;
 
         public CommunicationsHouseKeepingQueueTrigger(ILogger<CommunicationsHouseKeepingQueueTrigger> logger,
@@ -45,8 +45,8 @@ public async Task CommunicationsHouseKeepingAsync([QueueTrigger(QueueNames.Commu
                 var payload = JsonConvert.DeserializeObject<CommunicationsHouseKeepingQueueMessage>(message);
 
                 var targetDate = payload?.CreatedByScheduleDate ?? _timeProvider.Today;
-
-                var deleteCommunicationsMessagesBefore180Days = targetDate.AddDays(-180);
+                
+                var deleteCommunicationsMessagesBefore180Days = targetDate.AddDays((_jobsConfig.HardDeleteCommunicationMessagesStaleByDays ?? DefaultStaleByDays) * -1);                
 
                 await _communicationRepository.HardDelete(deleteCommunicationsMessagesBefore180Days);