-
-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.19.4 displays #5601
1.19.4 displays #5601
Conversation
…ature/displays
…ature/displays
src/main/java/ch/njol/skript/classes/data/DefaultFunctions.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/classes/data/DefaultFunctions.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/elements/expressions/ExprTextOf.java
Outdated
Show resolved
Hide resolved
...in/java/org/skriptlang/skript/elements/expressions/displays/text/ExprTextDisplayOpacity.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, mainly just went through the docs part this time.
src/main/java/org/skriptlang/skript/elements/expressions/displays/ExprDisplayInterpolation.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/elements/expressions/displays/ExprDisplayHeightWidth.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/elements/expressions/displays/ExprDisplayGlowOverride.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/elements/expressions/displays/ExprDisplayBillboard.java
Outdated
Show resolved
Hide resolved
...a/org/skriptlang/skript/elements/expressions/displays/ExprDisplayTransformationRotation.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/elements/expressions/displays/ExprDisplayViewRange.java
Outdated
Show resolved
Hide resolved
.../java/org/skriptlang/skript/elements/expressions/displays/text/ExprTextDisplayLineWidth.java
Outdated
Show resolved
Hide resolved
Co-authored-by: sovdee <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a slightly more clear version of this sentence, and the axisangle thing you already acknowledged, and I'm satisfied.
nice work!
src/main/java/org/skriptlang/skript/elements/expressions/displays/ExprDisplayHeightWidth.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing code-related, just some very small nitpicky things with descriptions and stuff
src/main/java/org/skriptlang/skript/bukkit/misc/expressions/ExprItemOfEntity.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/misc/expressions/ExprItemOfEntity.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/misc/expressions/ExprItemOfEntity.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/misc/expressions/ExprRotate.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/misc/expressions/ExprRotate.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/misc/expressions/ExprRotate.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/displays/generic/ExprDisplayBillboard.java
Outdated
Show resolved
Hide resolved
Co-authored-by: cheeezburga <[email protected]>
Co-authored-by: cheeezburga <[email protected]>
src/main/java/ch/njol/skript/classes/data/DefaultFunctions.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/displays/generic/ExprDisplayHeightWidth.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/misc/effects/EffRotate.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/misc/effects/EffRotate.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/misc/effects/EffRotate.java
Outdated
Show resolved
Hide resolved
Co-authored-by: cheeezburga <[email protected]>
# Conflicts: # build.gradle # src/main/java/ch/njol/skript/Skript.java # src/main/java/ch/njol/skript/classes/data/DefaultFunctions.java # src/main/java/ch/njol/skript/classes/data/JavaClasses.java # src/main/java/ch/njol/skript/classes/data/SkriptClasses.java # src/main/java/ch/njol/skript/effects/EffVectorRotateAroundAnother.java # src/main/java/ch/njol/skript/effects/EffVectorRotateXYZ.java # src/main/java/ch/njol/skript/expressions/ExprBlockData.java # src/main/java/ch/njol/skript/expressions/ExprColorOf.java # src/main/java/ch/njol/skript/expressions/ExprItemFrameSlot.java # src/main/java/ch/njol/skript/expressions/ExprVectorXYZ.java # src/main/java/ch/njol/skript/registrations/DefaultClasses.java # src/main/java/ch/njol/skript/util/ColorRGB.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Here's what I found this time around.
Also, it might be good to have more javadocs (at least at the class level) for the Rotator implementations.
src/main/java/org/skriptlang/skript/bukkit/misc/rotation/NonMutatingVectorRotator.java
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/misc/rotation/QuaternionRotator.java
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/misc/rotation/VectorRotator.java
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/misc/rotation/package-info.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Patrick Miller <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Truly excellent work. Just a few things, and then this should be ready to ship
src/main/java/org/skriptlang/skript/bukkit/displays/DisplayData.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/displays/generic/ExprDisplayViewRange.java
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/displays/text/ExprTextDisplayLineWidth.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/misc/rotation/NonMutatingQuaternionRotator.java
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/misc/rotation/NonMutatingVectorRotator.java
Show resolved
Hide resolved
Co-authored-by: Patrick Miller <[email protected]>
Description
Adds entity hiding because Spigot was finally forced to with these Displays.Download
Many people rely on this pull request. If you also wish to use this experimental version, go to the "checks" tab and then click Java 17, it'll have a skript-nightly.zip containing the built jar of this pull request.
Documentation at https://docs.skriptlang.org/nightly/feature/displays/docs.html
Ender chest loot box opening where it spins around and dumps out the contents as the reward (Requires Biosphere2)
Video of animation in #showcase https://discord.com/channels/135877399391764480/1072217309852213298/1111482138924163082
Target Minecraft Versions: 1.19.4
Requirements: none, but paper for some.
Related Issues: none