[WIP] Add kick message expr

[nopeless]

Description

Implement kick message getting and setting

---

Target Minecraft Versions: Not known yet

Related Issues:

https://discord.com/channels/135877399391764480/1332620961328926790

[Aresiel]

OMG I literally had this issue today and this PR was made like the second I found it. What are the odds.

[nopeless]

Annotations need proper skript version needs to be updated, hence the WIP

[Burbulinis]

This PR should target dev/feature, not master

[sovdeeth]

Annotations need proper skript version needs to be updated, hence the WIP

Any additions should use INSERT VERSION as a placeholder. It's automatically replaced during release

[sovdeeth]

This class needs to follow the proper code conventions re: method order, using finals in parameters, annotation placement.
But more importantly, this should probably be part of ExprMessage itself.

[nopeless]

working on the method order;

I don't think it should be part of ExprMessage, its not really a message that appears in chat. The reason why I named it ExprKickMessage is because kick reason was already taken

[sovdeeth]

there's no ExprKickReason, though?

[nopeless]

... good point, but then the class name would be ExprKickReason while the actual pattern is kick message and I thought that was worse

[sovdeeth]

Why would the pattern stay as kick message? shouldn't it be kick reason too?

[nopeless]

This should already be possible via ExprMessage

Skript/src/main/java/ch/njol/skript/expressions/ExprMessage.java

Lines 83 to 100 in 2bccb32

	QUIT("quit", "(quit|leave|log[ ]out|kick)( |-)message", PlayerQuitEvent.class, PlayerKickEvent.class) {
	@Override
	@Nullable
	String get(final Event e) {
	if (e instanceof PlayerKickEvent)
	return ((PlayerKickEvent) e).getLeaveMessage();
	else
	return ((PlayerQuitEvent) e).getQuitMessage();
	}
	@Override
	void set(final Event e, final String message) {
	if (e instanceof PlayerKickEvent)
	((PlayerKickEvent) e).setLeaveMessage(message);
	else
	((PlayerQuitEvent) e).setQuitMessage(message);
	}
	},

@Fusezion
This turns out to set the message in the chat not the kick message itself, hence the change

[Fusezion]

@Fusezion This turns out to set the message in the chat not the kick message itself, hence the change

Hmm, alright.

[nopeless]

@sovdeeth If you have a class name recommendation let me know because its very ambiguous overall

[TheAbsolutionism]

I know Sovde already mentioned about the coding conventions, so I won't do anything related to that.

[Efnilite]

Suggested change

	}
	}
	}
	}

[ShaneBeee]

In my opinion, rather than creating another expression, this should probably just be merged in with:
https://docs.skriptlang.org/expressions.html?search=#ExprMessage

[nopeless]

@ShaneBeee ExprMessage is what gets sent in chat, no? This is for what gets displayed on the player's screen

[ShaneBeee]

@ShaneBeee ExprMessage is what gets sent in chat, no? This is for what gets displayed on the player's screen

ohh ok gotcha. Anyways, wont your expression collide with kick message from ExprMessage?

[nopeless]

@ShaneBeee It does, currently, I'm not sure how to resolve it. My friends and people here has obviously said that all of this is ambiguous and I am leaving it up to maintainers to decide on the pattern and name

I originally wanted to name the class KickReason but after figuring out that kick reason is taken, I renamed it to KickMessage, only to realize that kick message is also taken so I hope you find something suitable

[Efnilite]

Suggested change

	Skript.registerExpression(ExprKickMessage.class, String.class, ExpressionType.SIMPLE, "kick (message|reason)");
	Skript.registerExpression(ExprKickMessage.class, String.class, ExpressionType.SIMPLE, "(display[ed]|on-screen) kick (message|reason)");

there should be a way to differentiate the chat kick message from this one

[Efnilite]

Suggested change

	@Name("Kick Message")
	@Name("On-screen Kick Message")

[nopeless]

@Efnilite I'm guessing that the expression pattern is final? (I don't know if you have discussed with others)

[Fusezion]

@Efnilite I'm guessing that the expression pattern is final? (I don't know if you have discussed with others)

Just providing my two cents, I would prefer going with Efy's changes here as that not only fixes conflictions but is descriptive enough that players can tell the difference between this and it's counter part

[Efnilite]

@Efnilite I'm guessing that the expression pattern is final? (I don't know if you have discussed with others)

if you have better suggestions feel free to use them, we just need to make sure its different

[nopeless]

I'll leave this open for a bit just in case someone wants to pitch in. personally I don't care what the pattern is as long as its usable