Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade plugin aliyun-ons-1.x #34

Closed

Conversation

bert82503
Copy link

@bert82503 bert82503 commented May 13, 2024

The #19 implementation reference from rocketMQ-3.x-plugin in Apache SkyWalking Java Agent.

But in fact, AliYun ons-client depends on org.apache.rocketmq:rocketmq-client:4.3.7.2, that needs to
rocketMQ-4.x-plugin.

This pull upgrade implementation to reference from rocketMQ-4.x-plugin.
Thanks.

image

@wu-sheng wu-sheng added this to the 2.4.0 milestone May 13, 2024
@wu-sheng
Copy link
Member

Are you from ONS team? We don't have env to verify this, and make sure your changes are proper.

@bert82503
Copy link
Author

bert82503 commented May 13, 2024

Are you from ONS team? We don't have env to verify this, and make sure your changes are proper.

Q: Are you from ONS team?
A: I am not from ONS team, we use AliYun ONS service and use SkyWalking to trace.

Q: We don't have env to verify this, and make sure your changes are proper.
A: Okay, let's do enough verification first, and then upload the screenshot.

Thanks brother. @wu-sheng

@wu-sheng
Copy link
Member

Thanks. This repo is not being watched and updated for months, as the plugins are stable and most are in the main repository only.

@bert82503
Copy link
Author

Thanks. This repo is not being watched and updated for months, as the plugins are stable and most are in the main repository only.

Okay, thanks.

@wu-sheng
Copy link
Member

Is this still in processing? We don't have verification channel for this plugin, as I am not an ONS user.

@bert82503
Copy link
Author

Is this still in processing? We don't have verification channel for this plugin, as I am not an ONS user.

I am so sorry, this plugin not in use.

@wu-sheng
Copy link
Member

If you wouldn't continue on this, let's close this.

@wu-sheng wu-sheng closed this Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants