-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade plugin aliyun-ons-1.x #34
Conversation
Are you from ONS team? We don't have env to verify this, and make sure your changes are proper. |
Q: Are you from ONS team? Q: We don't have env to verify this, and make sure your changes are proper. Thanks brother. @wu-sheng |
Thanks. This repo is not being watched and updated for months, as the plugins are stable and most are in the main repository only. |
Okay, thanks. |
Is this still in processing? We don't have verification channel for this plugin, as I am not an ONS user. |
I am so sorry, this plugin not in use. |
If you wouldn't continue on this, let's close this. |
The #19 implementation reference from rocketMQ-3.x-plugin in Apache SkyWalking Java Agent.
But in fact, AliYun
ons-client
depends onorg.apache.rocketmq:rocketmq-client:4.3.7.2
, that needs torocketMQ-4.x-plugin.
This pull upgrade implementation to reference from rocketMQ-4.x-plugin.
Thanks.