-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for bitcoin transactions/address generation #5
base: develop
Are you sure you want to change the base?
Support for bitcoin transactions/address generation #5
Conversation
@therealssj Could you explain, why this test should have |
@RomanMilishchuk the test is just that when the gateway method |
while you are at it can you also fix these test names |
@therealssj but why on the given inputs
|
@RomanMilishchuk the test is a check for what happens when the test is basically checking that this part of code https://github.com/SkycoinProject/hardware-wallet-daemon/blob/master/src/api/transaction_sign.go#L110 is working as it shud |
@Midren do you have any test params which work with the new
Usign that data the response was |
Changes:
Does this change need to mentioned in CHANGELOG.md?
yes
Requires testing
yes