Auth UI #411
Closed
Auth UI #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiootic
reviewed
Feb 11, 2020
chpapa
requested changes
Feb 12, 2020
chpapa
reviewed
Feb 17, 2020
chpapa
reviewed
Feb 19, 2020
1 task
louischan-oursky
force-pushed
the
370-auth-ui
branch
from
a3a9625 to
f1beac8
Compare
|
I have rewritten this PR. Various specs have been updated to reflect the new design. |
carmenlau
reviewed
Mar 2, 2020
|
|
||
| ### Custom domain | ||
|
|
||
| If the app is using custom domain, then Auth Gear is served at the developer's wish. |
There was a problem hiding this comment.
No sure how custom domain looks like after this change? Originally we only have one domain for all gears and Skygear App.
After auth ui is supported, developers can configure gears domain and skygear app domain separately?
There was a problem hiding this comment.
Yes. I should update the spec of custom domain to reflect this.
kiootic
reviewed
Mar 2, 2020
|
|
||
| ## Old SDK and old gateway behavior | ||
|
|
||
| When the SDK receives a response with `x-skygear-try-refresh-token: true`, it tries to refresh the access token. |
There was a problem hiding this comment.
We can try using silent authentication.
- Login at authorize, set cookie at AuthUI
- On app launch/expired -> call authorize with prompt = none
- AuthUI check cookie session: yes -> return code, no -> return 401
- Receive code & send token request, receive access_token + expires_in, NO REFRESH TOKEN
- When expires (according to expires_in): go to 1
- When receive 401: either revoked, or custom 401 -> goto 1
kiootic
reviewed
Mar 3, 2020
| - "https://example.com" | ||
| client_name: Web App | ||
| logo_uri: "https://example.com/logo.png" | ||
| disabled: false |
There was a problem hiding this comment.
remove this, spec is not updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #370
ref #382
Rendered document