Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for allowing unknown devices in rooms #127

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

koosc
Copy link

@koosc koosc commented Nov 10, 2024

Allows for sending messages with unknown unverified devices in the room. While not ideal to have enabled, this can provide a workaround for #118 until verification is fully implemented. If this gets merged in I can make the corresponding change to the e2ee branch as well.

Testing

I tested sending with it both enabled and disabled when encountering the error in the linked issue, confirming messages could then be sent. Let me know if there are any other specific tests I should do though.

image

Allows workaround for sending messages until verification is implemented
@koosc koosc changed the title Add option for allowing unknown devices Add option for allowing unknown devices in rooms Nov 10, 2024
@maru-sama
Copy link

Hello,

Yes this would be a working interim solution until there is an easy workflow to confirm the other devices. or even auto-confirm the m in a channel. Right now my notifications do not work at all, since I started them with an encrypted room and do not want to loose the history so cannot simply change that.

@skylord123
Copy link
Contributor

skylord123 commented Nov 13, 2024

This looks good and should be a nice temporary solution for users being blocked.

@koosc Can you change the base to the dev branch instead of master? I work on the next release under the dev branch and merge to master once a release is made. You can see what is slated for the next release here: #121 I will mention this addition once it gets merged. as well

Thanks for the PR :)

@koosc koosc changed the base branch from master to dev November 13, 2024 04:45
@koosc
Copy link
Author

koosc commented Nov 13, 2024

Makes sense, I updated the target branch. It looks like it doesn't need any changes from the original commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants