Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatin (I)Engine - depcreate and add methods dealing with alarms #3701

Merged
merged 12 commits into from
Sep 27, 2024
Merged

Automatin (I)Engine - depcreate and add methods dealing with alarms #3701

merged 12 commits into from
Sep 27, 2024

Conversation

RobbeDGH
Copy link
Contributor

wdm-slc
wdm-slc approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@wdm-slc wdm-slc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (cannot verify if the resulting docs look ok though)

src/DataMiner/SLNetTypes/Info/IDObjects/AlarmTreeID.cs
/// Represents a reference to one specific alarm tree.
/// </summary>
[Serializable]
public sealed class AlarmTreeID //: DMAObjectRef, IEquatable<AlarmTreeID>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we also need to list the properties like ElementID and RootAlarmID ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like a good idea yeah

@RobbeDGH
Copy link
Contributor Author

@wdm-slc, to see the resulting docs from this you need to use buildDocs.cmd instead of the raw docfx build command

@RobbeDGH
Copy link
Contributor Author

Note there is somthing wrong with displaying the AlarmID class, not sure what.
This is not fixed.

Think it might be related to the namespace Skyline.DataMiner.Net.Messages.SLDataGateway being present in multiple dlls

@RobbeDGH RobbeDGH marked this pull request as ready for review September 27, 2024 07:33
@RobbeDGH RobbeDGH requested a review from a team as a code owner September 27, 2024 07:33
wdm-slc
wdm-slc approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@wdm-slc wdm-slc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MariekeGO MariekeGO self-assigned this Sep 27, 2024
@MariekeGO MariekeGO merged commit ab60b44 into SkylineCommunications:main Sep 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wdm-slc wdm-slc wdm-slc approved these changes

@MariekeGO MariekeGO MariekeGO approved these changes

Assignees

@MariekeGO MariekeGO

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RobbeDGH @MariekeGO @wdm-slc